Page MenuHomeFreeBSD

Include existing MAKE_PARAMS_<target> when determining the universe toolchain.
ClosedPublic

Authored by jhb on Jun 28 2018, 5:18 PM.

Details

Summary

This fixes a warning for each RISCV target during universe by passing in
the required CROSS_TOOLCHAIN setting which will in turn set
CROSS_BINUTILS_PREFIX correctly. It also ensures that a tinderbox build
uses the correct compiler for riscv. Previously it was using the shared
clang compiler instead of riscv64-gcc.

Test Plan
  • make tinderbox with riscv64-xtoolchain-gcc installed demonstrated the failure. I used 'make tinderbox -V MAKE_PARAMS_riscv' to test which showed XCC, etc. set along with CROSS_TOOLCHAIN before this change, and with this change only CROSS_TOOLCHAIN is present. I've restarted the tinderbox build but it will take a while to finish.
  • Ravi had reported the warning yesterday which this fixes for me which is why I've added him on the cc.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

While my tinderbox is still running, the riscv64 buildworld is now compiling things with the right compiler (previously it died trying to compile the very first thing in libcompiler_rt and it's beyond that stage now)

This revision is now accepted and ready to land.Jun 28 2018, 6:17 PM
This revision was automatically updated to reflect the committed changes.