Added flavors support to www/drush
ClosedPublic
Actions

Authored by mfechner on Jun 24 2018, 9:01 AM.

Details

Reviewers

swills
tz

Commits

rP473390: Added flavors support to drush.

Summary

Commit message:
Added flavors support to drush.

I will refer to PR 227741.

Test Plan

Port build with poudriere and modified patch to make portlint happy.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

mfechner created this revision.Jun 24 2018, 9:01 AM

Herald added a subscriber: mat. · View Herald TranscriptJun 24 2018, 9:01 AM

While the patch is fine, UPDATING needs an entry for it!

This revision now requires changes to proceed.Jun 25 2018, 1:02 PM

There is already an entry existing (20180611).
If we start to add for each php application an entry that will cause the UPDATING file to explode or?

In D15990#338873, @mfechner wrote:

There is already an entry existing (20180611).
If we start to add for each php application an entry that will cause the UPDATING file to explode or?

Nope. Also this entry is for the past. There are even more, like for 20180518 or 20180412.

The problem with not doing it because of 20180611 is: when using pkg updating with an date after 20180611 you wont notice it. And you need to fix the problem by yourself. So its better to have a short notice. You can even reference 20180611 if you want. But do not surprise the user with an unexpected problem ;)

Added entry in UPDATING.

Thanks swills! :)

This revision is now accepted and ready to land.Jun 26 2018, 7:47 AM

Closed by commit rP473390: Added flavors support to drush. (authored by mfechner). · Explain WhyJun 26 2018, 3:33 PM

This revision was automatically updated to reflect the committed changes.