Sent via PR 229172
Awaiting maintainer approval or timeout (on July 5th).
Differential D15970
net/fping: update to 4.0 fernape on Jun 22 2018, 6:12 PM. Authored by Tags None Referenced Files
Subscribers
Details
Sent via PR 229172 Awaiting maintainer approval or timeout (on July 5th).
Note that I don't have an IPv6 address so I only tested IPv4 [fernape@freefall ~]$ ./fping ipv6.google.com
Diff Detail
Event TimelineComment Actions This port is required by several others -- can you check that none of them expect fping6 to be present? Comment Actions Link fping to fping6 since a bunch of other ports (net-mgmt/librenms and others) Comment Actions Thanks for following up on this :)
Comment Actions Thanks for pointing it out! :-) A question about procedure: What I did was find all the Makefiles which had net/fping in them and for every one of them, go and extract the distfile and see if they used fping6. I was lucky because I found a port at my third attempt :-) but... is there a better way to do something like this? Comment Actions Yeah, also what I would have done :D -- you could have used freshports.org to get the list of the ports to look at -- I normally grep in the INDEX file to get a list of dependencies: awk -F '|' '/fping-3/{print $2}' /usr/ports/INDEX-12 Comment Actions Is there any reason to keep the options? Is the package so much bigger with both IPv4 and IPv6 defined? It feels there should be no options and everything should be installed at once. Comment Actions No, it's basically the same size.
Makes sense since the same executable handles both protocols now. I'll update the patch in the PR and await maintainer approval. Comment Actions You may need to add --enable-ipv6 --enable-ipv4 to CONFIGURE_ARGS.
Comment Actions It seems there is not need. It compiles and works fine without passing them explicitly. Comment Actions In the configure world "seem to work" is not really good enough, it may do things under the hood that you cannot guess |