audit(4): Add tests for connect(2), connectat(2) and accept(2)
ClosedPublic
Actions

Authored by aniketp on Jun 16 2018, 5:01 PM.

Details

Reviewers

asomers
rwatson
gnn

Commits

rS335294: audit(4): add tests for connect, connectat, and accept

Summary

This revision introduces atf-c(3) test cases to check the auditablity of 3 system calls
classified in nework audit class, in both success and failure mode
The system calls are:

connect(2)
connectat(2)
accept(2)

Test Plan

Execute make install from usr.sbin/praudit/tests.
Execute kyua test from /usr/test/usr.sbin/praudit. The test case should succeed.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

aniketp created this revision.Jun 16 2018, 5:01 PM

Harbormaster completed remote builds in B17349: Diff 43907.Jun 16 2018, 5:01 PM

asomers requested changes to this revision.Jun 17 2018, 3:37 PM

asomers added inline comments.

tests/sys/audit/network.c
409 ↗	(On Diff #43907)	You can combine the `socket` and `fcntl` calls by putting `SOCK_NONBLOCK` in `socket`'s `type` argument.
457 ↗	(On Diff #43907)	0 is standard input. Better to use -1 for the bad file descriptor.
566 ↗	(On Diff #43907)	Since you don't use client, you may as well set it to NULL.