Page MenuHomeFreeBSD

Use a unified packing list for base/binutils.
ClosedPublic

Authored by jhb on Jun 14 2018, 7:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 17 2024, 7:35 PM
Unknown Object (File)
Jan 8 2024, 10:24 AM
Unknown Object (File)
Sep 29 2023, 2:50 AM
Unknown Object (File)
Sep 24 2023, 12:29 AM
Unknown Object (File)
Sep 13 2023, 12:53 PM
Unknown Object (File)
Jul 9 2023, 7:39 PM
Unknown Object (File)
Jun 25 2023, 6:34 AM
Unknown Object (File)
Jun 19 2023, 1:46 AM
Subscribers

Details

Summary

Create a single pkg-plist that uses arch-specific PLIST_SUBs to control
arch-specific linker scripts but is otherwise machine-independent.

  • Only include objcopy for OS versions older than 11.0 (11.0 uses the elftoolchain elfcopy as objcopy in the base system)
  • Use %%BUTARGET%% throughout. This probably fixes the sparc64 pkg-plist which was not updated when BUTARGET started including OSREL. This also avoids hardcoding an OSREL of 12.0 for powerpc64.
  • Enable MIPS ldscripts for all MIPS architectures which probably fixes this port on mips64 and mipsn32.
  • Enable PowerPC ldscripts for all PowerPC architectures which probably fixes this port on powerpc.
Test Plan
  • built and used freebsd-binutils for FreeBSD/mips

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 17284
Build 17121: arc lint + arc unit

Event Timeline

I'm not sure why phab failed to upload the contents of pkg-plist.

Try to update to see if pkg-plist is fixed.

Sigh, silly arc. Anyway, if I could use a single glob line of '%%BUTARGET%%/lib/ldscripts/*' in the pkg-plist file that would make the plist a lot simpler and would remove the need for any arch-specific logic in the plist.

(You can find the current pkg-plist file that arcanist refuses to upload in /zoo/jhb/ports/base/binutils/pkg-plist on zoo.freebsd.org)

Ping. Also curious if you (or anyone else) has thoughts about being able to use 'ldscripts/*' in pkg-plist. It would make this plist a lot simpler and simplify porting this package to other platforms (I think it would then just work on all of our supported platforms). There is similar mischief for GCC's include directory which includes different headers based on the target architecture (the include/ dir for intrinsic headers like xmmintrin.h etc.)

Can you link your patch from freefall so I can see the plist contents?

Looks fine / approved. I'm not a maintainer of this port though.
As for 'ldscripts/*' I support that (autoplist style) but in general no other portmgr does (and bapt certainly does not) since it does not fail if an expected file is missing.

This revision is now accepted and ready to land.Jun 25 2018, 11:54 PM