Page MenuHomeFreeBSD
Differential D15810

aw_ccung: Add a10/a20 support
ClosedPublic
Actions

Authored by kevans on Jun 14 2018, 5:15 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Sep 22, 4:33 PM
Unknown Object (File)
Sat, Sep 20, 10:05 PM
Unknown Object (File)
Sep 3 2025, 12:56 PM
Unknown Object (File)
Sep 3 2025, 11:13 AM
Unknown Object (File)
Aug 16 2025, 1:29 AM
Unknown Object (File)
Aug 14 2025, 11:11 PM
Unknown Object (File)
Aug 6 2025, 10:32 AM
Unknown Object (File)
Jul 15 2025, 12:38 PM
View All 60 Files
Subscribers
andrew
imp

Details

Reviewers
manu
Commits
rS335165: aw_ccung: Add a10/a20 support
Summary

Tested on: Lamobo R1/Banana Pi R1 (A20)

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kevans created this revision.Jun 14 2018, 5:15 PM
Herald added subscribers: andrew, imp. · View Herald TranscriptJun 14 2018, 5:16 PM
Harbormaster completed remote builds in B17276: Diff 43773.Jun 14 2018, 5:16 PM
kevans added a parent revision: D15806: aw_ccung: Support clock factors where factor=0, factor is effectively 1.Jun 14 2018, 5:17 PM
manu added a comment.Jun 14 2018, 5:24 PM

I prefer spliting the A10 and A20 right now even if for now they are the same.

kevans added a comment.Jun 14 2018, 5:27 PM
In D15810#334274, @manu wrote:

I prefer spliting the A10 and A20 right now even if for now they are the same.

As in, duplicate all of these common clocks? There's only like five extra clocks that the a20 has, so I was planning on just doing something slightly different in ccu_a20_register_clocks after registering all of the common/a10 clocks.

manu added a comment.Jun 14 2018, 5:34 PM
In D15810#334278, @kevans wrote:
In D15810#334274, @manu wrote:

I prefer spliting the A10 and A20 right now even if for now they are the same.

As in, duplicate all of these common clocks? There's only like five extra clocks that the a20 has, so I was planning on just doing something slightly different in ccu_a20_register_clocks after registering all of the common/a10 clocks.

Ah ok, yeah I guess that works too.
I'll review the code tomorow and test on some boards too.

manu accepted this revision.Jun 14 2018, 5:40 PM

Well in fact just commit it, it's better to have a few broken clocks that nothing at all.
I accept the review but do not add me to reviewed-by as I haven't read the clock definition.

This revision is now accepted and ready to land.Jun 14 2018, 5:40 PM
Closed by commit rS335165: aw_ccung: Add a10/a20 support (authored by kevans). · Explain WhyJun 14 2018, 5:50 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
arm/
allwinner/
a10/
1 line
a20/
1 line
clkng/
2 lines
20 lines
36 lines
612 lines

Diff 43776

View Options

head/sys/arm/allwinner/a10/files.a10

Loading...
View Options

head/sys/arm/allwinner/a20/files.a20

Loading...
View Options

head/sys/arm/allwinner/clkng/aw_ccung.h

Loading...
View Options

head/sys/arm/allwinner/clkng/aw_ccung.c

Loading...
View Options

head/sys/arm/allwinner/clkng/ccu_a10.h

Loading...
View Options

head/sys/arm/allwinner/clkng/ccu_a10.c

Loading...