Page MenuHomeFreeBSD
Differential D15795

Initialize file-attribute-modify audit class
ClosedPublic
Actions

Authored by aniketp on Jun 14 2018, 2:09 AM.
Tags
None
Referenced Files
F142369293: D15795.id43739.diff
Mon, Jan 19, 4:52 AM
F142367836: D15795.id.diff
Mon, Jan 19, 4:21 AM
F142366404: D15795.id43734.diff
Mon, Jan 19, 3:50 AM
F142365339: D15795.id43751.diff
Mon, Jan 19, 3:28 AM
Unknown Object (File)
Sun, Jan 18, 2:50 PM
Unknown Object (File)
Sat, Jan 17, 3:55 AM
Unknown Object (File)
Fri, Jan 16, 2:54 AM
Unknown Object (File)
Mon, Dec 29, 1:34 AM
View All Files
Subscribers
imp

Details

Reviewers
asomers
rwatson
gnn
Commits
rS335136: audit(4): add tests for flock, fcntl, and fsync
Summary

This revision introduces a new test program file-attribute-modify which deals with
auditing any syscall responsible for modification of file attributes (as the name suggests)
System calls introduced are:

  • flock(2)
  • fcntl(2)
  • fsync(2)
Test Plan

Execute make && make install from test/sys/audit.
Execute kyua test from /usr/tests/sys/audit. All testcases should succeed.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

aniketp created this revision.Jun 14 2018, 2:09 AM
Harbormaster completed remote builds in B17247: Diff 43734.Jun 14 2018, 2:09 AM
aniketp edited the summary of this revision. (Show Details)Jun 14 2018, 2:29 AM
aniketp set the repository for this revision to rS FreeBSD src repository - subversion.
Herald added a subscriber: imp. · View Herald TranscriptJun 14 2018, 2:29 AM
asomers requested changes to this revision.Jun 14 2018, 2:34 AM
asomers added inline comments.
tests/sys/audit/file-attribute-modify.c
35 ↗(On Diff #43734)

No magic numbers, please.

This revision now requires changes to proceed.Jun 14 2018, 2:34 AM
aniketp updated this revision to Diff 43739.Jun 14 2018, 3:01 AM

Replace F_DUPFD with F_GETFL as the cmd
Note: This eliminates the need of LOWEST_FD

Harbormaster completed remote builds in B17251: Diff 43739.Jun 14 2018, 3:01 AM
asomers accepted this revision.Jun 14 2018, 1:36 PM
This revision is now accepted and ready to land.Jun 14 2018, 1:36 PM
Closed by commit rS335136: audit(4): add tests for flock, fcntl, and fsync (authored by asomers). · Explain WhyJun 14 2018, 1:43 PM
This revision was automatically updated to reflect the committed changes.
asomers added inline comments.Jun 14 2018, 2:48 PM
head/tests/sys/audit/Makefile
6

Whoops! This change broke file-attribute-access. I didn't notice it during the original review. I'll fix it.

Revision Contents
Changeset List

PathSize
head/
tests/
sys/
audit/
3 lines
199 lines

Diff 43751

View Options

head/tests/sys/audit/Makefile

Loading...
View Options

head/tests/sys/audit/file-attribute-modify.c

Loading...