Paths

Table of Contentst

Differential D15636

Add tests for readlink(2) and readlinkat(2) system calls
ClosedPublic
Actions

Authored by aniketp on May 31 2018, 5:31 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Apr 22, 12:08 PM

	Unknown Object (File)
	Mon, Apr 21, 10:28 AM

	Unknown Object (File)
	Tue, Apr 15, 4:50 AM

	Unknown Object (File)
	Mon, Apr 14, 9:34 AM

	Unknown Object (File)
	Mon, Apr 14, 3:45 AM

	Unknown Object (File)
	Mon, Apr 14, 12:37 AM

	Unknown Object (File)
	Sun, Apr 13, 11:50 PM

	Unknown Object (File)
	Sun, Apr 13, 9:50 PM

View All 90 Files

Subscribers

Details

Reviewers

asomers
gnn
rwatson

Commits

rS339087: MFC many audit(4) tests.
rS334471: audit(4): Add tests for the fr class of syscalls

Summary

The following changes introduce a new test-program file-read, apart from the already existing 24 tests for fc "file-create" audit class which were introduced in D15286 and committed as rS334360. These 4 test-cases check the proper audit of readlink(2) and readlinkat(2) for both success and failure case.

Test Plan

Execute make && make install from test/sys/audit.
Execute kyua test from /usr/tests/sys/audit. All testcases should succeed.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

aniketp created this revision.May 31 2018, 5:31 PM

Herald added a subscriber: imp. · View Herald TranscriptMay 31 2018, 5:31 PM

Other than the copyright header, it LGTM.

tests/sys/audit/file-read.c
3 ↗	(On Diff #43209)	As Mateusz said, you should remove "All rights reserved"

This revision now requires changes to proceed.May 31 2018, 5:58 PM

Remove the "All Rights Reserved" from file-create.c and file-read.c

Remove "All rights reserved" from utils.c and utils.h

asomers accepted this revision.May 31 2018, 11:08 PM

This revision is now accepted and ready to land.May 31 2018, 11:08 PM

Closed by commit rS334471: audit(4): Add tests for the fr class of syscalls (authored by asomers). · Explain WhyJun 1 2018, 1:37 AM

This revision was automatically updated to reflect the committed changes.

aniketp mentioned this in D15640: Add tests for truncate(2) and ftruncate(2) system calls.Jun 1 2018, 2:21 AM

Revision Contents
Changeset List

Path

Size

head/

tests/

sys/

audit/

3 lines

1 line

136 lines

1 line

1 line

Diff 43223

head/tests/sys/audit/Makefile

Loading...

head/tests/sys/audit/file-create.c

Loading...

head/tests/sys/audit/file-read.c

Loading...

head/tests/sys/audit/utils.h

Loading...

head/tests/sys/audit/utils.c

Loading...