Enable high-speed on the card before increasing frequency on the controller
ClosedPublic
Actions

Authored by kibab on May 25 2018, 9:46 AM.

Tags

Referenced Files

	F170780832: D15568.id43332.diff
	Sun, Sep 6, 2:30 PM

	F170750569: D15568.id.diff
	Sun, Sep 6, 10:03 AM

	Unknown Object (File)
	Sat, Sep 5, 6:09 PM

	Unknown Object (File)
	Sat, Sep 5, 11:31 AM

	Unknown Object (File)
	Thu, Sep 3, 1:14 AM

	Unknown Object (File)
	Tue, Sep 1, 9:45 PM

	Unknown Object (File)
	Tue, Sep 1, 12:50 AM

	Unknown Object (File)
	Sun, Aug 30, 9:04 PM

View All Files

Subscribers

None

Details

Reviewers

imp

Commits

rS334651: Enable high-speed on the card before increasing frequency on the controller

Summary

Increasing operating frequency without telling card to switch to high-speed mode first upsets some cards and generates CRC errors.
While here, deselect / reselect cards after CMD6 and SCR fetch, as in original code.

Test Plan

This diff enables normal operation for the following card: <SDHC SL16G 8.0 SN 19853490 MFG 01/2017> with Raspberry Pi 3 host.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kibab created this revision.May 25 2018, 9:46 AM

Harbormaster completed remote builds in B16838: Diff 42975.May 25 2018, 9:46 AM

other than the minor style nits, this looks good.

sys/cam/mmc/mmc_da.c
904 ↗	(On Diff #42975)	style says this { is alone on the next line.
905 ↗	(On Diff #42975)	and no blank line here.

This revision is now accepted and ready to land.Jun 4 2018, 8:27 PM

kibab marked 2 inline comments as done.Jun 5 2018, 11:03 AM

Closed by commit rS334651: Enable high-speed on the card before increasing frequency on the controller (authored by kibab). · Explain WhyJun 5 2018, 11:03 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

cam/

mmc/

mmc_da.c

70 lines

Diff 43332

View Options

Enable high-speed on the card before increasing frequency on the controllerClosedPublicActions