Merge the arm, mips, and powerpc copies of the libthr tcb ctor/dtor.

[andrew]

Summary

These three architectures have almost identical copies of this file. This
merges them into a single copy.

The old PowerPC version is different as it uses an alignment of 1 where the
other architectures used 16. I have changed this to 16, but am not sure if
this is valid for PowerPC.

[emaste]

Hmm, the trivial_ prefix made sense for getcontextx I think because it did indeed implement a trivial version. I wonder though if we should instead use common_ for these cases, since some of the shared files may not be trivial.

[andrew]

Mere all copies of pthread_md.c in to a single file based on sparc64.

The amd64 and i386 copies had asm to get the tcb. I replaced this with
_tcb_get() and checked before and after and found the object files were
identical.

The arm, mips, and powerpc _rtld_allocate_tls will return the first
argument if it's non-null. _tcb_get() will return the pointer to the tcb
on the initial thread so this will be returned.

[kib]

I do not see much sense in calling the file xxx_md.c when it is mi. Call it pthread_ctrdtr.c and move to libthr/thread directory ?

[andrew]

In D1556#5, @emaste wrote:

Hmm, the trivial_ prefix made sense for getcontextx I think because it did indeed implement a trivial version. I wonder though if we should instead use common_ for these cases, since some of the shared files may not be trivial.

I don't mind what it's called. It would make sense to name it common_pthread.c or something similar now it looks like all copies can be merged.

[emaste]

In D1556#9, @andrew wrote:

I don't mind what it's called. It would make sense to name it common_pthread.c or something similar now it looks like all copies can be merged.

@kostikbel's suggestion sounds good to me.

[andrew]

In D1556#8, @kostikbel wrote:

I do not see much sense in calling the file xxx_md.c when it is mi. Call it pthread_ctrdtr.c and move to libthr/thread directory ?

Sure, we can move it there, although should it be something like thr_ctrdtr.c in that case? All other source files in that directory use the thr_ prefix.

[kib]

Also, to finish the cleanup, copies of the prototypes for tcb_ctor and dtor should be moved to thr_private.h.

[andrew]

• Move the common file to libthr/thread/thr_ctrdtr.c
• Move the prototypes to thr_private.h

[kib]

lib/libthr/Makefile

47 ↗

(On Diff #3264)

Is this directory needed still ?

[andrew]

lib/libthr/Makefile

47 ↗

(On Diff #3264)

No, I'll remove it from the committed patch.

[andrew]

Remove the reference to arch/common

[andrew]

Closed by commit rS277490 (authored by @andrew).