Page MenuHomeFreeBSD

Rewrite USB device mode chapter
ClosedPublic

Authored by trasz on May 21 2018, 6:37 PM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 20 2023, 4:08 AM
Unknown Object (File)
Dec 15 2023, 12:58 PM
Unknown Object (File)
Nov 10 2023, 3:09 PM
Unknown Object (File)
Nov 10 2023, 9:18 AM
Unknown Object (File)
Nov 9 2023, 2:26 PM
Unknown Object (File)
Nov 8 2023, 3:53 PM
Unknown Object (File)
Nov 8 2023, 3:18 PM
Unknown Object (File)
Nov 8 2023, 9:23 AM
Subscribers

Diff Detail

Repository
rD FreeBSD doc repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Thank you for updating the handbook chapter with your work on USB device mode. I added some things I've found. Mostly minor things, easy to fix.

en_US.ISO8859-1/books/handbook/usb-device-mode/chapter.xml
35 ↗(On Diff #42807)

I would introduce the acronym OTG in parentheses here (right after "On the Go"), so that people that are reading on know what it stands for.

56 ↗(On Diff #42807)

You don't need to break the line here prematurely (this is not a man page ;-)).

58 ↗(On Diff #42807)

same here.

72 ↗(On Diff #42807)

There must be an empty line here to separate the </para> from the new <para>.

121 ↗(On Diff #42807)

s/the need special/the need for special/

123 ↗(On Diff #42807)

Pull this line up into the one above.

145 ↗(On Diff #42807)

The indentation seems off here. The <scree> needs to be on the same level as the <para>s above and below.

157 ↗(On Diff #42807)

Make an empty line before <screen> appear here. ;-)

166 ↗(On Diff #42807)

/as laptop/as a laptop/

168 ↗(On Diff #42807)

the "pstat -t" would be better when wrapped in <command> tags. You can leave out the " then. Also, remove the "the" and "command" before and after it. You can rewrite it like this:

Use <command>pstat -t</command> on the host to list the terminal lines.

or

List terminal lines on the host using <command>pstat -t</command>

171 ↗(On Diff #42807)

Another empty line here.

176 ↗(On Diff #42807)

One more empty line at this position.

186 ↗(On Diff #42807)

Another ... (you know what I mean). ;-)

196 ↗(On Diff #42807)

And another...

201 ↗(On Diff #42807)

s/as laptop/as a laptop/ (same as above)

202 ↗(On Diff #42807)

s/open connection/open a connection/

203 ↗(On Diff #42807)

s/Putty/<application>PuTTY</application>/

207 ↗(On Diff #42807)

s/Putty/<application>PuTTY</application>/

208 ↗(On Diff #42807)

Same here for Putty.

277 ↗(On Diff #42807)

I think it would make sense to wrap the cfumass into <filename> tags here, as the sentence is referencing the file/script directly.

281 ↗(On Diff #42807)

And another empty line...

287 ↗(On Diff #42807)

Time for an empty line...

en_US.ISO8859-1/books/handbook/usb-device-mode/chapter.xml
34 ↗(On Diff #42807)

use of?

44 ↗(On Diff #42807)

maybe we should add something like "or a combination thereof"?

51 ↗(On Diff #42807)

probably drop "the usual host mode". client port implies it's not host mode.

73–75 ↗(On Diff #42807)

too many clauses in this sentence

Fixes from bcr@ and emaste@.

en_US.ISO8859-1/books/handbook/usb-device-mode/chapter.xml
73–75 ↗(On Diff #42807)

You're probably right, but I'm not sure how to split it.

Looks good to me now, approved!

This revision is now accepted and ready to land.May 29 2018, 2:02 PM
This revision was automatically updated to reflect the committed changes.