This comes from PR 228176
Improve some aspects of the port:
- add DESKTOP_ENTRY
- add converters/base64 as BUILD_DEPENDS
- add icons
Also give maintainership to submitter who already maintains other ports.
Paths
| Differential D15480 Authored by fernape on May 18 2018, 4:35 PM.
Details
Summary This comes from PR 228176 Improve some aspects of the port:
Also give maintainership to submitter who already maintains other ports. Test Plan
Diff Detail
Event TimelineHerald added a subscriber: mat. ยท View Herald TranscriptMay 18 2018, 4:35 PM2018-05-18 16:35:55 (UTC+0) Harbormaster completed remote builds in B16671: Diff 42701.May 18 2018, 4:35 PM2018-05-18 16:35:56 (UTC+0) Comment Actions
I'm not very familiar with common icon formats. I'll suggest the reporter to change the format. Thanks! Comment Actions My issue is more with them being shipped in files/ and not downloaded from somewhere -- you could for example create a tkdiff-icons.tar.gz and host it in your public distfiles and add it as an additional distfile. portmaster_BSDforge.com added a subscriber: portmaster_BSDforge.com.May 21 2018, 3:24 AM2018-05-21 03:24:27 (UTC+0) Comment Actions
Icky? Seriously? Comment Actions
I'd argue that that adds more complexity, than my implementation. Base64 has been used since near the dawn of email for handling attachments. Browsers have been using it since the late 20th century for everything from favicons, to embedding sprites, and images within the accompanying css files. In fact google gives higher rankings for that. Granted; this is not a web page, nor email. But IMHO this seems a great deal more efficient, than downloading an additional archive, and then processing it's contents. Thanks! --Chris
Comment Actions Thanks Mat! Thanks again. --Chris Harbormaster completed remote builds in B16744: Diff 42816.May 21 2018, 9:29 PM2018-05-21 21:29:23 (UTC+0) Comment Actions @mat does not seem to mind it, so it's OK, I gueess =) But could you give them more sensible names like tkdiff-256.png.enc or something instead of just 256. Comment Actions
OK I've done it. Please see D15509 I think we're done here. :-) --Chris Harbormaster completed remote builds in B16766: Diff 42858.May 22 2018, 9:02 PM2018-05-22 21:02:32 (UTC+0) This revision is now accepted and ready to land.May 23 2018, 3:59 AM2018-05-23 03:59:21 (UTC+0) Comment Actions
Hi Tobias, I can't commit this patch. A svn hook prevents it: Committing transaction... Additional errors may compound and may not be accuratePath "head/textproc/tkdiff/files/icon256.base64" is missing the svn:keywords property (or an fbsd:nokeywords override) Pre-commit problem count: 4I have all the properties mentioned here: What properties are necessary to commit these files? Comment Actions
I would say they should have svn:eol-style=native; fbsd:nokeywords=yes; svn:mime-type=text/plain. Closed by commit rP470725: textproc/tkdiff: port improvements (authored by fernape). ยท Explain WhyMay 23 2018, 9:59 PM2018-05-23 21:59:57 (UTC+0) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 42903 head/textproc/tkdiff/Makefile
head/textproc/tkdiff/files/icon128.base64
head/textproc/tkdiff/files/icon256.base64
head/textproc/tkdiff/files/icon32.base64
|