Fix mld6query(8) and add a new -g option
ClosedPublic
Actions

Authored by shurd on May 10 2018, 5:06 PM.

Details

Reviewers

sbruno
mmacy
ume

Group Reviewers

manpages

Commits

rS333501: Fix mld6query(8) and add a new -g option

Summary

The mld6query command relies on KAME behaviour which allows the
ipv6mr_multiaddr member of the request object in a IPV6_JOIN_GROUP
setsockopt() call to be INADDR6_ANY. The FreeBSD stack doesn't allow
this, so mld6query has been non-functional.

Also, add a -g option which sends a General Query (query INADDR6_ANY)

Test Plan

Ensure all message types function as expected

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

shurd created this revision.May 10 2018, 5:06 PM

Herald added a reviewer: manpages. · View Herald TranscriptMay 10 2018, 5:06 PM

Herald added a subscriber: imp. · View Herald Transcript

Harbormaster completed remote builds in B16519: Diff 42371.May 10 2018, 5:06 PM

Add ume since he's the last one to actually touch this code (14 years ago).

Leave the same group we joined.

Harbormaster completed remote builds in B16520: Diff 42373.May 10 2018, 5:23 PM

sbruno accepted this revision.May 10 2018, 5:38 PM

This revision is now accepted and ready to land.May 10 2018, 5:38 PM

mmacy accepted this revision.May 11 2018, 6:01 PM

Closed by commit rS333501: Fix mld6query(8) and add a new -g option (authored by shurd). · Explain WhyMay 11 2018, 7:37 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

usr.sbin/

mld6query/

mld6.c

44 lines

mld6query.8

6 lines

Diff 42427

View Options

head/usr.sbin/mld6query/mld6.c