Page MenuHomeFreeBSD

Allow arbitrary numbers of columns in the VNC server.
ClosedPublic

Authored by grehan on May 2 2018, 9:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sep 27 2024, 12:51 PM
Unknown Object (File)
Sep 24 2024, 8:39 AM
Unknown Object (File)
Sep 21 2024, 5:55 AM
Unknown Object (File)
Sep 14 2024, 8:14 AM
Unknown Object (File)
Sep 8 2024, 11:55 PM
Unknown Object (File)
Sep 7 2024, 4:30 PM
Unknown Object (File)
Sep 2 2024, 3:26 AM
Unknown Object (File)
Aug 27 2024, 9:28 AM
Subscribers

Details

Summary

The prior code only allowed multiples of 32 for the
numbers of columns. Remove this restriction to allow
a forthcoming UEFI firmware update to allow arbitrary
x,y resolutions.

(the code for handling rows already supported values
that weren't multiples of 32)

Reviewed by Leon Dang, the original author.

Test Plan

The modified UEFI image at www.freebsd.org/~grehan/BHYVE_GOP_ares.fd
can be used to test this.

Tested with UEFI, Ubuntu live CDs, and FreeBSD with various
strange resolutions.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 16403
Build 16328: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.May 4 2018, 1:37 AM
This revision was automatically updated to reflect the committed changes.