Page MenuHomeFreeBSD

Allow arbitrary numbers of columns in the VNC server.
ClosedPublic

Authored by grehan on May 2 2018, 9:47 PM.

Details

Summary

The prior code only allowed multiples of 32 for the
numbers of columns. Remove this restriction to allow
a forthcoming UEFI firmware update to allow arbitrary
x,y resolutions.

(the code for handling rows already supported values
that weren't multiples of 32)

Reviewed by Leon Dang, the original author.

Test Plan

The modified UEFI image at www.freebsd.org/~grehan/BHYVE_GOP_ares.fd
can be used to test this.

Tested with UEFI, Ubuntu live CDs, and FreeBSD with various
strange resolutions.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

grehan created this revision.May 2 2018, 9:47 PM
This revision was not accepted when it landed; it landed in state Needs Review.May 4 2018, 1:37 AM
This revision was automatically updated to reflect the committed changes.