Differential D15169

For video consoles, only launch a getty if the device exists.
ClosedPublic
Actions

Authored by imp on Apr 23 2018, 2:57 PM.

Details

Reviewers

trasz

Commits

rS333436: For video consoles, only launch a getty if the device exists.

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 16264
Build 16212: arc lint + arc unit

Event Timeline

imp created this revision.Apr 23 2018, 2:57 PM

Herald added a subscriber: emaste. · View Herald TranscriptApr 23 2018, 2:57 PM

Harbormaster completed remote builds in B16264: Diff 41762.Apr 23 2018, 2:57 PM

imp added a reviewer: trasz.Apr 23 2018, 2:59 PM

Looks good. Have you thought about merging the files into a single, architecture-independent one?

This revision is now accepted and ready to land.Apr 23 2018, 6:16 PM

In D15169#319696, @trasz wrote:

Looks good. Have you thought about merging the files into a single, architecture-independent one?

I've thought about it, but there's still enough difference that I want to give it more thought. I'm thinking a default ttys file with a per-arch override would be better since MIPS is unlikely to ever have video console support, for example. I'd like to think about it in the back of my head for a bit.

I'm pretty sure we have MIPS boards (well, BERI running in FPGA, but still) with Terasic... screen-thingys with console on them, here at Cambridge. Not sure how it's configured regarding ttys(5), though, or if it even goes through vt(4) - although it certainly looks like a text console.

Closed by commit rS333436: For video consoles, only launch a getty if the device exists. (authored by imp). · Explain WhyMay 9 2018, 8:49 PM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: andrew. · View Herald TranscriptMay 9 2018, 8:49 PM

In D15169#319736, @trasz wrote:

I'm pretty sure we have MIPS boards (well, BERI running in FPGA, but still) with Terasic... screen-thingys with console on them, here at Cambridge. Not sure how it's configured regarding ttys(5), though, or if it even goes through vt(4) - although it certainly looks like a text console.

That's why I'm approaching this with some caution. I'll have a common file, but then allow people to override it. But I'm torn about that, since it's more an image assembly issue to change it rather than a per-arch thing, so I'll cook on it for a bit.

Perhaps have a common file (can't help but notice it seems to be the only per-arch etc/ file, so we could get rid of the whole mechanism this way), and have per-image overrides specified by release/*/WHATEVER.conf files, like the rest of per-image things?

In D15169#324670, @trasz wrote:

Perhaps have a common file (can't help but notice it seems to be the only per-arch etc/ file, so we could get rid of the whole mechanism this way), and have per-image overrides specified by release/*/WHATEVER.conf files, like the rest of per-image things?

But release/*/WHATEVER.conf isn't used for mergemaster and etcupdate... so we can't just run head-long into this...