Differential D15156

vmmdev: return EFAULT when trying to read beyond VM system memory max address
ClosedPublic
Actions

Authored by antoine on Apr 22 2018, 7:30 AM.

Tags

None

Referenced Files

	F132378263: D15156.id41720.diff
	Thu, Oct 16, 9:19 AM

	Unknown Object (File)
	Mon, Oct 13, 4:51 AM

	Unknown Object (File)
	Sun, Oct 12, 8:42 AM

	Unknown Object (File)
	Sat, Sep 27, 12:20 AM

	Unknown Object (File)
	Fri, Sep 26, 1:26 PM

	Unknown Object (File)
	Wed, Sep 24, 11:05 AM

	Unknown Object (File)
	Sun, Sep 21, 5:57 PM

	Unknown Object (File)
	Sun, Sep 21, 10:44 AM

View All 79 Files

Subscribers

Details

Reviewers

rgrimes
imp
grehan
anish

Group Reviewers

Commits

rS333639: vmmdev: return EFAULT when trying to read beyond VM system memory max address

Summary

Currently, when using dd(1) to take a VM memory image, the capture never ends,
reading zeroes when it's beyond VM system memory max address.
Return EFAULT when trying to read beyond VM system memory max address.
With the patch, I'm able to take a memory image from a windows guest with dd(1)
and analyse it with tools like volatility or rekall.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

antoine created this revision.Apr 22 2018, 7:30 AM

Herald added a reviewer: rgrimes. · View Herald TranscriptApr 22 2018, 7:30 AM

Herald added a subscriber: imp. · View Herald Transcript

Harbormaster completed remote builds in B16253: Diff 41720.Apr 22 2018, 7:30 AM

imp accepted this revision.Apr 22 2018, 3:16 PM

This revision is now accepted and ready to land.Apr 22 2018, 3:16 PM

antoine added a reviewer: grehan.Apr 22 2018, 9:32 PM

This revision now requires review to proceed.Apr 22 2018, 9:32 PM

Good to go with the name change.

sys/amd64/include/vmm.h
215 ↗	(On Diff #41720)	Can the name for this be changed to vmm_sysmem_maxaddr ?

This revision is now accepted and ready to land.May 14 2018, 7:13 AM

anish accepted this revision.May 14 2018, 7:00 PM

Closed by commit rS333639: vmmdev: return EFAULT when trying to read beyond VM system memory max address (authored by antoine). · Explain WhyMay 15 2018, 5:21 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

amd64/

include/

1 line

vmm/

6 lines

5 lines

Diff 42591

head/sys/amd64/include/vmm.h

Loading...

head/sys/amd64/vmm/vmm.c

Loading...

head/sys/amd64/vmm/vmm_dev.c

Loading...