Page MenuHomeFreeBSD

new port: sysutils/coreos-ct
ClosedPublic

Authored by fabian.freyer_physik.tu-berlin.de on Apr 17 2018, 2:45 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Oct 11, 5:41 AM
Unknown Object (File)
Fri, Oct 4, 11:41 AM
Unknown Object (File)
Thu, Oct 3, 11:42 PM
Unknown Object (File)
Tue, Oct 1, 10:41 PM
Unknown Object (File)
Sat, Sep 28, 5:35 PM
Unknown Object (File)
Thu, Sep 26, 5:33 PM
Unknown Object (File)
Mon, Sep 23, 4:54 PM
Unknown Object (File)
Mon, Sep 23, 10:25 AM

Details

Summary

The Config Transpiler, ct, is the utility responsible for transforming a
user-provided Container Linux Configuration into an Ignition configuration.
The resulting Ignition config can then be provided to a Container Linux machine
when it first boots in order to provision it.

WWW: https://coreos.com/os/docs/latest/overview-of-ct.html

see https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=227584

Test Plan
  • portlint
  • poudriere testport
  • minimal smoke testing of the produced binary

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

0mp requested changes to this revision.May 11 2018, 5:00 PM
0mp added a subscriber: 0mp.

Looks fine to me. I didn't test it though.

sysutils/coreos-ct/Makefile
11 ↗(On Diff #41572)

Is there a license file in the upstream repository? If so, then it is a good idea to define LICENSE_FILE here.

22 ↗(On Diff #41572)

Do you think that it is a good idea to include some additional documentation? It looks like there's a directory with some doc files: https://github.com/coreos/container-linux-config-transpiler/tree/master/doc

This revision now requires changes to proceed.May 11 2018, 5:00 PM

updated to 0.9.0 and addressed @0mp's comments:

  • added LICENSE_FILE
  • included documentation
This revision is now accepted and ready to land.May 25 2018, 4:14 PM
sysutils/coreos-ct/Makefile
5 ↗(On Diff #42994)

missing tab here.

14 ↗(On Diff #42994)

Don't USES=go if you overwrite all its targets, just add a dependency on go itself.

This revision now requires review to proceed.May 26 2018, 4:51 PM
sysutils/coreos-ct/Makefile
14 ↗(On Diff #42994)

I do use several variables from Mk/Uses/go.mk though, namely GO_ENV, GO_CMD. Should I copy those from Mk/Uses/go.mk too, or just keep this?

sysutils/coreos-ct/Makefile
14 ↗(On Diff #42994)

Mmmm, ok, do keep it. It seems a bit silly that with go being very standardised, the default USES=go very often does not do what is needed, but it is not really your problem here, more a framework one. :(

This revision was not accepted when it landed; it landed in state Needs Review.Jun 2 2018, 2:17 PM
This revision was automatically updated to reflect the committed changes.