new port: sysutils/coreos-ct
ClosedPublic
Actions

Authored by fabian.freyer_physik.tu-berlin.de on Apr 17 2018, 2:45 PM.

Details

Reviewers

0mp

Commits

rP471370: New port: sysutils/coreos-ct, a Container Linux Config Transpiler

Summary

The Config Transpiler, ct, is the utility responsible for transforming a
user-provided Container Linux Configuration into an Ignition configuration.
The resulting Ignition config can then be provided to a Container Linux machine
when it first boots in order to provision it.

WWW: https://coreos.com/os/docs/latest/overview-of-ct.html

see https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=227584

Test Plan

portlint
poudriere testport
minimal smoke testing of the produced binary

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

fabian.freyer_physik.tu-berlin.de created this revision.Apr 17 2018, 2:45 PM

Herald added subscribers: Contributor Reviewers (ports), mat. · View Herald TranscriptApr 17 2018, 2:45 PM

fabian.freyer_physik.tu-berlin.de edited the summary of this revision. (Show Details)Apr 17 2018, 4:48 PM

Looks fine to me. I didn't test it though.

sysutils/coreos-ct/Makefile
12	Is there a license file in the upstream repository? If so, then it is a good idea to define `LICENSE_FILE` here.
23	Do you think that it is a good idea to include some additional documentation? It looks like there's a directory with some doc files: https://github.com/coreos/container-linux-config-transpiler/tree/master/doc

This revision now requires changes to proceed.May 11 2018, 5:00 PM

updated to 0.9.0 and addressed @0mp's comments:

added LICENSE_FILE
included documentation

fabian.freyer_physik.tu-berlin.de marked 2 inline comments as done.May 25 2018, 4:10 PM

0mp accepted this revision.May 25 2018, 4:14 PM

This revision is now accepted and ready to land.May 25 2018, 4:14 PM

mat added inline comments.May 25 2018, 10:27 PM

sysutils/coreos-ct/Makefile
6	missing tab here.
15	Don't USES=go if you overwrite all its targets, just add a dependency on go itself.

added tab

This revision now requires review to proceed.May 26 2018, 4:51 PM

fabian.freyer_physik.tu-berlin.de added inline comments.May 26 2018, 4:51 PM

sysutils/coreos-ct/Makefile
15	I do use several variables from `Mk/Uses/go.mk` though, namely `GO_ENV`, `GO_CMD`. Should I copy those from `Mk/Uses/go.mk` too, or just keep this?

fabian.freyer_physik.tu-berlin.de marked an inline comment as done.May 26 2018, 4:58 PM

mat added inline comments.May 26 2018, 8:36 PM

sysutils/coreos-ct/Makefile
15	Mmmm, ok, do keep it. It seems a bit silly that with go being very standardised, the default USES=go very often does not do what is needed, but it is not really your problem here, more a framework one. :(