stand/i386: pass --no-rosegment when linking with lld
ClosedPublic
Actions

Authored by emaste on Apr 3 2018, 8:16 PM.

Details

Reviewers

imp
kevans

Commits

rS332090: stand: pass --no-rosegment for i386 bits when linking with lld

Summary

btxld does not correctly handle input with other than 2 PT_LOAD segments. Passing --no-rosegment lets lld produce output equivalent to ld.bfd: 2 PT_LOAD segments and no PT_GNU_RELRO.

PR: 225775

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

emaste created this revision.Apr 3 2018, 8:16 PM

emaste added a subscriber: bdrewery.

imp added inline comments.Apr 3 2018, 9:47 PM

stand/i386/Makefile.inc
9	Do you need defined(LINKER_TYPE)?

kevans added inline comments.Apr 3 2018, 9:50 PM

stand/i386/Makefile.inc
9	I believe make(1) will complain about a malformed conditional without it, as unfriendly as that is.

emaste added inline comments.Apr 3 2018, 10:17 PM

stand/i386/Makefile.inc
9	It's a concession to people (e.g., bde) who might build these bits outside of buildworld - the idea being that the .sinclude means there will be no failure if bsd.linker.mk is not found, and in that case LINKER_TYPE will not be defined. If we don't need to support that case we can replace the `.sinclude` with `.include` and drop the `defined (LINKER_TYPE) &&` bit.

This revision was not accepted when it landed; it landed in state Needs Review.Apr 6 2018, 2:58 AM

Closed by commit rS332090: stand: pass --no-rosegment for i386 bits when linking with lld (authored by emaste). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

stand/

i386/

Makefile.inc

5 lines

Diff 41049

View Options

stand/i386: pass --no-rosegment when linking with lldClosedPublicActions