Page MenuHomeFreeBSD

stand/i386: pass --no-rosegment when linking with lld
ClosedPublic

Authored by emaste on Apr 3 2018, 8:16 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 5, 10:32 PM
Unknown Object (File)
Fri, Apr 5, 4:37 PM
Unknown Object (File)
Mar 27 2024, 4:34 AM
Unknown Object (File)
Mar 23 2024, 11:49 PM
Unknown Object (File)
Mar 7 2024, 8:01 PM
Unknown Object (File)
Jan 19 2024, 2:29 PM
Unknown Object (File)
Dec 23 2023, 11:39 AM
Unknown Object (File)
Dec 20 2023, 8:35 AM
Subscribers

Details

Summary

btxld does not correctly handle input with other than 2 PT_LOAD segments. Passing --no-rosegment lets lld produce output equivalent to ld.bfd: 2 PT_LOAD segments and no PT_GNU_RELRO.

PR: 225775

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste added a subscriber: bdrewery.
stand/i386/Makefile.inc
9 ↗(On Diff #41049)

Do you need defined(LINKER_TYPE)?

stand/i386/Makefile.inc
9 ↗(On Diff #41049)

I believe make(1) will complain about a malformed conditional without it, as unfriendly as that is.

stand/i386/Makefile.inc
9 ↗(On Diff #41049)

It's a concession to people (e.g., bde) who might build these bits outside of buildworld - the idea being that the .sinclude means there will be no failure if bsd.linker.mk is not found, and in that case LINKER_TYPE will not be defined.

If we don't need to support that case we can replace the .sinclude with .include and drop the defined (LINKER_TYPE) && bit.

This revision was not accepted when it landed; it landed in state Needs Review.Apr 6 2018, 2:58 AM
This revision was automatically updated to reflect the committed changes.