Page MenuHomeFreeBSD

Fix astro/qmapshack build with CMake 3.11
ClosedPublic

Authored by adridg on Apr 2 2018, 2:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 10 2024, 3:32 AM
Unknown Object (File)
Dec 31 2023, 7:15 PM
Unknown Object (File)
Dec 31 2023, 1:08 AM
Unknown Object (File)
Dec 8 2023, 1:23 PM
Unknown Object (File)
Dec 8 2023, 1:23 PM
Unknown Object (File)
Dec 8 2023, 1:19 PM
Unknown Object (File)
Dec 2 2023, 11:27 PM
Unknown Object (File)
Nov 23 2023, 1:46 PM
Subscribers

Details

Summary

CMake 3.11 builds auto-moc'ed files in a slightly different order from
how CMake 3.10 did. This shows up when files don't have all their
pre-requisite includes #included in the new order.

Add the required include for a complete definition of IDrawContext, to
fix this compiler error:

src/qmapshack/qmapshack_autogen/G2GOEHWAFX/../../dem/CDemVRT.h:36:15: error: incomplete type 'IDrawContext' named in nested name specifier

void draw(IDrawContext::buffer_t& buf) override;
          ^~~~~~~~~~~~~~

src/qmapshack/canvas/CCanvas.h:31:7: note: forward declaration of 'IDrawContext'
class IDrawContext;

Test Plan

Builds on 11.1-amd64 with CMake 3.10 and CMake 3.11

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 15939
Build 15931: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Apr 2 2018, 8:19 PM
This revision was automatically updated to reflect the committed changes.