Page MenuHomeFreeBSD

Rename constant FW_DEVICE_UNINORTH to FW_DEVICE_UNINORTH2
ClosedPublic

Authored by sevan on Mar 31 2018, 6:50 PM.
Tags
None
Referenced Files
F132790978: D14919.diff
Sun, Oct 19, 11:55 PM
Unknown Object (File)
Sep 15 2025, 4:34 AM
Unknown Object (File)
Sep 10 2025, 6:56 AM
Unknown Object (File)
Sep 7 2025, 10:50 PM
Unknown Object (File)
Sep 1 2025, 12:46 PM
Unknown Object (File)
Aug 13 2025, 12:21 PM
Unknown Object (File)
Aug 10 2025, 12:28 PM
Unknown Object (File)
Aug 2 2025, 3:19 AM
Subscribers

Details

Summary

Device id 0x0031 is actually the UniNorth 2 Firewire controller, the original
UniNorth Firewire controller is 0x0018.

See https://pci-ids.ucw.cz/read/PC/106b

Update constant and description.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 15910
Build 15903: arc lint + arc unit

Event Timeline

We should have both, no?

Also, why do we have two identical copies of this list? The boot loader can reach over into the kernel for stuff like this....

Finally, any desire to make the driver lookup table driven rather than case-statement driven?

Other than that, I suppose it's fine :)

OK, I've just deleted fwohcireg.h from stand, so that part of the patch isn't needed :)

In D14919#313724, @imp wrote:

We should have both, no?

In theory, yes, but the first version is a different chipset & there may be some issues. Certainly on NetBSD there are deadlocks currently (an the Firewire code is derived from FreeBSD)
So long story short, it needs testing on FreeBSD first :)

Finally, any desire to make the driver lookup table driven rather than case-statement driven?

Sure, I can take a look.

In D14919#313725, @imp wrote:

OK, I've just deleted fwohcireg.h from stand, so that part of the patch isn't needed :)

thanks :)

This revision was not accepted when it landed; it landed in state Needs Review.Apr 1 2018, 12:25 AM
This revision was automatically updated to reflect the committed changes.

Committed as rS331858 since it is a no-brainer commit. Please submit any future changes through a new review :).
Thanks!