Page MenuHomeFreeBSD

Rename constant FW_DEVICE_UNINORTH to FW_DEVICE_UNINORTH2
ClosedPublic

Authored by sevan on Mar 31 2018, 6:50 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 7 2024, 2:27 AM
Unknown Object (File)
Jan 28 2024, 5:37 PM
Unknown Object (File)
Dec 20 2023, 5:50 AM
Unknown Object (File)
Dec 17 2023, 2:15 PM
Unknown Object (File)
Aug 21 2023, 12:12 AM
Unknown Object (File)
Aug 7 2023, 11:39 AM
Unknown Object (File)
Aug 7 2023, 11:37 AM
Unknown Object (File)
Aug 7 2023, 11:37 AM
Subscribers

Details

Summary

Device id 0x0031 is actually the UniNorth 2 Firewire controller, the original
UniNorth Firewire controller is 0x0018.

See https://pci-ids.ucw.cz/read/PC/106b

Update constant and description.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

We should have both, no?

Also, why do we have two identical copies of this list? The boot loader can reach over into the kernel for stuff like this....

Finally, any desire to make the driver lookup table driven rather than case-statement driven?

Other than that, I suppose it's fine :)

OK, I've just deleted fwohcireg.h from stand, so that part of the patch isn't needed :)

In D14919#313724, @imp wrote:

We should have both, no?

In theory, yes, but the first version is a different chipset & there may be some issues. Certainly on NetBSD there are deadlocks currently (an the Firewire code is derived from FreeBSD)
So long story short, it needs testing on FreeBSD first :)

Finally, any desire to make the driver lookup table driven rather than case-statement driven?

Sure, I can take a look.

In D14919#313725, @imp wrote:

OK, I've just deleted fwohcireg.h from stand, so that part of the patch isn't needed :)

thanks :)

This revision was not accepted when it landed; it landed in state Needs Review.Apr 1 2018, 12:25 AM
This revision was automatically updated to reflect the committed changes.

Committed as rS331858 since it is a no-brainer commit. Please submit any future changes through a new review :).
Thanks!