x86: improve reservation of AP trampoline memory
ClosedPublic
Actions

Authored by royger on Mar 28 2018, 11:14 AM.

Details

Reviewers

kib
jhb

Commits

rS332073: x86: improve reservation of AP trampoline memory

Summary

So that it doesn't rely on physmap[1] containing an address below
1MiB. Instead scan the full physmap and search for a suitable address
to place the trampoline code (below 1MiB) and the initial memory pages
(below 4GiB).

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

royger created this revision.Mar 28 2018, 11:14 AM

Harbormaster completed remote builds in B15844: Diff 40834.Mar 28 2018, 11:14 AM

kib added inline comments.Mar 28 2018, 4:21 PM

sys/i386/i386/mp_machdep.c
148 ↗	(On Diff #40834)	Can you share this function between 386 and amd64 ?
sys/sys/param.h
367 ↗	(On Diff #40834)	This should be committed separately.

Thanks, new version coming up.

sys/i386/i386/mp_machdep.c
148 ↗	(On Diff #40834)	Yes, I've placed it in mp_x86.c
sys/sys/param.h
367 ↗	(On Diff #40834)	OK, I can do this. IMO I don't like to introduce functions/macros/whatever without a caller on the same patch.