Page MenuHomeFreeBSD

lualoader: Add hook.lua(8) to tree
ClosedPublic

Authored by kevans on Mar 24 2018, 12:15 AM.
Tags
None
Referenced Files
F106067252: D14815.diff
Tue, Dec 24, 8:22 PM
Unknown Object (File)
Wed, Nov 27, 4:04 AM
Unknown Object (File)
Wed, Nov 27, 4:04 AM
Unknown Object (File)
Wed, Nov 27, 4:03 AM
Unknown Object (File)
Wed, Nov 27, 4:03 AM
Unknown Object (File)
Wed, Nov 27, 4:03 AM
Unknown Object (File)
Wed, Nov 27, 3:42 AM
Unknown Object (File)
Nov 23 2024, 9:48 AM
Subscribers

Details

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

It would be good if you explained what a hook was, somewhere before the Exported functions section.

stand/lua/hook.lua.8
61

"to be run"

66

Describe the ordering in which multiple hooks of the same hooktype are run.

69

"in, as well"

73

is defined in the
.Xr config.lua 8
module, and run when the configuration is reloaded.

75

"to be run"

kevans marked 5 inline comments as done.

Address comments by @rpokala

  • Nuke all instances of 'ran' from orbit, use 'run' instead
  • Describe order in which hooks are invoked
  • Add a cross-reference and a missing article

Re-word the description a little bit, explain what hooks are and what we mean by "hook types".

rpokala requested changes to this revision.Jun 8 2018, 3:48 AM
rpokala added inline comments.
stand/lua/hook.lua.8
5

Per discussions over the last few months, remove "All rights reserved."

This revision now requires changes to proceed.Jun 8 2018, 3:48 AM
This revision was not accepted when it landed; it landed in state Needs Revision.Jun 9 2018, 2:27 PM
This revision was automatically updated to reflect the committed changes.