Paths

Table of Contentst

Differential D14815

lualoader: Add hook.lua(8) to tree
ClosedPublic
Actions

Authored by kevans on Mar 24 2018, 12:15 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Nov 27, 4:04 AM

	Unknown Object (File)
	Wed, Nov 27, 4:04 AM

	Unknown Object (File)
	Wed, Nov 27, 4:03 AM

	Unknown Object (File)
	Wed, Nov 27, 4:03 AM

	Unknown Object (File)
	Wed, Nov 27, 4:03 AM

	Unknown Object (File)
	Wed, Nov 27, 3:42 AM

	Unknown Object (File)
	Nov 23 2024, 9:48 AM

	Unknown Object (File)
	Nov 23 2024, 6:17 AM

View All 80 Files

Subscribers

Details

Reviewers

Group Reviewers

Commits

rS334879: lualoader: Add hook.lua(8) to tree

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kevans created this revision.Mar 24 2018, 12:15 AM

Herald added a reviewer: manpages. · View Herald TranscriptMar 24 2018, 12:15 AM

Herald added a subscriber: imp. · View Herald Transcript

Harbormaster completed remote builds in B15755: Diff 40664.Mar 24 2018, 12:15 AM

It would be good if you explained what a hook was, somewhere before the Exported functions section.

stand/lua/hook.lua.8
60 ↗	(On Diff #40664)	"to be run"
65 ↗	(On Diff #40664)	Describe the ordering in which multiple hooks of the same `hooktype` are run.
68 ↗	(On Diff #40664)	"in, as well"
72 ↗	(On Diff #40664)	is defined in the .Xr config.lua 8 module, and run when the configuration is reloaded.
74 ↗	(On Diff #40664)	"to be run"

Address comments by @rpokala

Nuke all instances of 'ran' from orbit, use 'run' instead
Describe order in which hooks are invoked
Add a cross-reference and a missing article

Harbormaster completed remote builds in B15758: Diff 40667.Mar 24 2018, 3:00 AM

Re-word the description a little bit, explain what hooks are and what we mean by "hook types".

rpokala requested changes to this revision.Jun 8 2018, 3:48 AM

rpokala added inline comments.

stand/lua/hook.lua.8
5 ↗	(On Diff #40668)	Per discussions over the last few months, remove "All rights reserved."

This revision now requires changes to proceed.Jun 8 2018, 3:48 AM

This revision was not accepted when it landed; it landed in state Needs Revision.Jun 9 2018, 2:27 PM

Closed by commit rS334879: lualoader: Add hook.lua(8) to tree (authored by kevans). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

stand/

lua/

94 lines

Diff 43489

head/stand/lua/hook.lua.8

Loading...