Page MenuHomeFreeBSD

lualoader: Add hook.lua(8) to tree
ClosedPublic

Authored by kevans on Mar 24 2018, 12:15 AM.

Details

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

kevans created this revision.Mar 24 2018, 12:15 AM

It would be good if you explained what a hook was, somewhere before the Exported functions section.

stand/lua/hook.lua.8
60 ↗(On Diff #40664)

"to be run"

65 ↗(On Diff #40664)

Describe the ordering in which multiple hooks of the same hooktype are run.

68 ↗(On Diff #40664)

"in, as well"

72 ↗(On Diff #40664)

is defined in the
.Xr config.lua 8
module, and run when the configuration is reloaded.

74 ↗(On Diff #40664)

"to be run"

kevans updated this revision to Diff 40667.Mar 24 2018, 3:00 AM
kevans marked 5 inline comments as done.

Address comments by @rpokala

  • Nuke all instances of 'ran' from orbit, use 'run' instead
  • Describe order in which hooks are invoked
  • Add a cross-reference and a missing article
kevans updated this revision to Diff 40668.Mar 24 2018, 3:04 AM

Re-word the description a little bit, explain what hooks are and what we mean by "hook types".

rpokala requested changes to this revision.Jun 8 2018, 3:48 AM
rpokala added inline comments.
stand/lua/hook.lua.8
5 ↗(On Diff #40668)

Per discussions over the last few months, remove "All rights reserved."

This revision now requires changes to proceed.Jun 8 2018, 3:48 AM
This revision was not accepted when it landed; it landed in state Needs Revision.Jun 9 2018, 2:27 PM
This revision was automatically updated to reflect the committed changes.