Fix cad/kicad build with future CMake versions
ClosedPublic
Actions

Authored by adridg on Mar 20 2018, 6:37 PM.

Tags

None

Referenced Files

	F163306799: D14772.id.diff
	Tue, Jul 21, 10:25 PM

	Unknown Object (File)
	Mon, Jul 20, 10:41 AM

	Unknown Object (File)
	Sun, Jul 19, 5:46 AM

	Unknown Object (File)
	Sat, Jul 18, 2:19 PM

	Unknown Object (File)
	Thu, Jul 16, 12:07 PM

	Unknown Object (File)
	Tue, Jul 7, 10:22 AM

	Unknown Object (File)
	Sat, Jul 4, 10:44 PM

	Unknown Object (File)
	Sat, Jul 4, 6:19 PM

View All Files

Subscribers

mat

Details

Reviewers

tcberner
rakuco
thierry

Commits

rP465282: Fix cad/kicad{-devel} in advance of CMake 3.11. Remove old duplicate CMake

Summary

The old modules use CMake internals that are going away in 3.11;
this particular module has been shipped with CMake since 3.0 at least,
so it's just not necessary except on silly ancient platforms.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

adridg created this revision.Mar 20 2018, 6:37 PM

Herald added a subscriber: mat. · View Herald TranscriptMar 20 2018, 6:37 PM

Harbormaster completed remote builds in B15665: Diff 40509.Mar 20 2018, 6:37 PM

Looks good to me.

This revision is now accepted and ready to land.Mar 20 2018, 7:10 PM

The same fix applies to kicad-devel; I'd just like an "ack" from the maintainer.

thierry accepted this revision.Mar 21 2018, 5:30 PM

Closed by commit rP465282: Fix cad/kicad{-devel} in advance of CMake 3.11. Remove old duplicate CMake (authored by adridg). · Explain WhyMar 22 2018, 9:53 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

cad/

kicad-devel/

Makefile

8 lines

kicad/

Makefile

8 lines

Diff 40592

View Options

head/cad/kicad-devel/Makefile