Move locks from outside ioctl to the individual implementations.
This is the first step of changing the implementations to act on a
kernel-internal request struct rather than on struct md_ioctl and to
removing the use of kern_ioctl in mountroot.
Details
Details
- Reviewers
kib cem markj - Commits
- rS331014: Move implementation of ioctls into kern_*() functions.
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| sys/dev/md/md.c | ||
|---|---|---|
| 1776–1777 ↗ | (On Diff #40305) | else break? Doesn't seem to be any point in continuing the loop once the output buffer is full. That can wait for a separate commit though. |
Comment Actions
With this structure, I would expect the lock to be pushed into individual ioctl routines, in fact.
| sys/dev/md/md.c | ||
|---|---|---|
| 1747 ↗ | (On Diff #40305) | Perhaps use the opportunity and return EFAULT if this copyout failed ? |
Comment Actions
I'll update following @kib's suggestions shortly.
| sys/dev/md/md.c | ||
|---|---|---|
| 1776–1777 ↗ | (On Diff #40305) | The continued looping is to finish counting which is the ABI (both a count and a terminator, historically the terminator only existed if the set didn't fit). The ABI is broken by design and prior to r330880 the loop was a kernel buffer overflow. |
| sys/dev/md/md.c | ||
|---|---|---|
| 1776–1777 ↗ | (On Diff #40305) | If that's what it's for, it's broken now. We won't ever increment i again. Probably need else i++; or similar. |
| sys/dev/md/md.c | ||
|---|---|---|
| 1776–1777 ↗ | (On Diff #40305) | Oops, fixed in HEAD, will fix here. |
Comment Actions
- Rebase
- Return immediatly if copyout of md_label fails.
- Move locking into command implementations.
- Unconditionally increment count to preserve ABI.