[new port] devel/pyotherside, Python3 bindings for use in QML
ClosedPublic
Actions

Authored by daniel_shafer.cc on Mar 13 2018, 1:30 PM.

Details

Reviewers

bapt
adridg
tcberner

Commits

rP486388: New port: devel/pyotherside-qt5 -- Python3 bindings for use in QML

Summary

Pyotherside is a QML plugin that provides access to a Python3 interpreter
from within QML.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 21303
Build 20636: arc lint + arc unit

Event Timeline

adridg created this revision.Mar 13 2018, 1:30 PM

Herald added a subscriber: mat. · View Herald TranscriptMar 13 2018, 1:30 PM

Harbormaster completed remote builds in B15539: Diff 40243.Mar 13 2018, 1:30 PM

This fails to configure for me:

===>  Configuring for pyotherside-1.5.3
Info: creating stash file /wrkdirs/usr/ports/devel/pyotherside/work/pyotherside-1.5.3/.qmake.stash
Reading /wrkdirs/usr/ports/devel/pyotherside/work/pyotherside-1.5.3/src/src.pro
Project MESSAGE: PYTHON_CONFIG = python3-config
sh: python3-config: not found
sh: python3-config: not found
Project ERROR: Unknown module(s) in QT: core gui qml quick svg
*** Error code 3

Actually get it to build in poudriere :/

I'm not really comfortable with the QMAKE_ARGS there,
and have the nagging feeling that this thing needs flavor.

Harbormaster completed remote builds in B15580: Diff 40317.Mar 15 2018, 3:27 PM

tcberner added inline comments.Mar 15 2018, 4:07 PM

devel/pyotherside/Makefile
4 ↗	(On Diff #40317)	DISTVERSION is prefered

mat added inline comments.Mar 21 2018, 1:28 PM

devel/pyotherside/Makefile
6 ↗	(On Diff #40317)	Remove.
21 ↗	(On Diff #40317)	Default, remove.

linimon retitled this revision from Add a port for pyotherside to [new port] devel/pyotherside.Jul 18 2018, 12:51 PM

linimon retitled this revision from [new port] devel/pyotherside to [new port] devel/pyotherside, Python3 bindings for use in QML.

Ping

tcberner commandeered this revision.Dec 1 2018, 3:33 PM

tcberner edited reviewers, added: adridg; removed: tcberner.

daniel_shafer.cc commandeered this revision.Dec 1 2018, 4:41 PM

daniel_shafer.cc added a reviewer: tcberner.

Updated Makefile

Worked with tcberner on updating the Makefile, added qt5 suffix. Added proper
USE flags. Ensured dependencies were correct. Built fine in poudriere, passes
port lint

Harbormaster completed remote builds in B21298: Diff 51475.Dec 1 2018, 5:02 PM

There are some minor improvents you can do. After that, it can go in :)

devel/pyotherside-qt5/Makefile
5	^ `DISTVERSION= 1.5.3` is preferered
9	^ you could take it yourself :)
16	^ these two, you can replace by a `USE_GL=gl` down by the other uses.
18	^ `make stage-qa` complains about a missing `gettext-runtime` in the USES.
19	`buildtools` is generally only needed during the build-stage and not once the software is being usied. So you can do that as `buildtools_buid`. I would also sort those lists alphabetically, and orther them by the kind (nothing, _build, _run,) USE_QT= core declarative gui network quickcontrols svg testlib widgets \ buildtools_build This is mostly useful to quickly find stuff by eye :)
23	^ you can get rid of this, as it is the default value (=${PORTNAME}).
25	^ `QMAKE_ARGS= PYTHON_CONFIG=${PYTHON_CMD}-config` is shorter :)