Set kldxref_enable="YES" for ARM images
ClosedPublic
Actions

Authored by trasz on Feb 27 2018, 4:32 PM.

Details

Reviewers

emaste
gjb

Commits

rS333493: Set kldxref_enable="YES" for ARM images. Without it, the images are missing

Summary

Set kldxref_enable="YES" for ARM images. Without this, the images are missing the /boot/kernel/linker.hints file, which breaks loading some of the modules with dependencies, eg cfiscsi.ko. It would be better to run kldxref(8) when building the images, but at this point that tool cannot handle files for architectures other than its own.

Note that I don't really have a way to test this change, so any help here would be welcome.

This fixes https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=218166.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

trasz created this revision.Feb 27 2018, 4:32 PM

Herald added subscribers: andrew, imp. · View Herald TranscriptFeb 27 2018, 4:32 PM

Harbormaster completed remote builds in B15303: Diff 39794.Feb 27 2018, 4:33 PM

trasz retitled this revision from Set kldxref_enable="YES" for ARM images. to Set kldxref_enable="YES" for ARM images.Feb 27 2018, 4:34 PM

trasz edited the summary of this revision. (Show Details)

trasz added reviewers: emaste, gjb.

trasz edited the summary of this revision. (Show Details)

Now I think about this, I think we should actually just change the default. The reason is that it's required for every image that's being cross-built (kldxref(1) cannot handle files from non-native architectures); for ones that are not cross-built (ie amd64) having it on by default won't do anything - the script is noop if the linker.hints already exists. It will result in a message during boot, however; I have another review (https://reviews.freebsd.org/D14694) that should fix it.

gjb accepted this revision.May 9 2018, 2:10 PM

This revision is now accepted and ready to land.May 9 2018, 2:10 PM

Closed by commit rS333493: Set kldxref_enable="YES" for ARM images. Without it, the images are missing (authored by trasz). · Explain WhyMay 11 2018, 2:52 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

release/

tools/

arm.subr

1 line

Diff 42408

View Options

head/release/tools/arm.subr

Set kldxref_enable="YES" for ARM imagesClosedPublicActions