Remove a bogus assertion from vm_page_launder().
ClosedPublic
Actions

Authored by markj on Feb 23 2018, 5:12 PM.

Details

Reviewers

alc
kib
jeff

Commits

rS329885: Remove a bogus assertion from vm_page_launder().

Summary

After r328977, a page m may have m->queue != PQ_NONE and
m->wire_count > 0.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Feb 23 2018, 5:12 PM

Harbormaster completed remote builds in B15224: Diff 39645.Feb 23 2018, 5:12 PM

markj added reviewers: alc, kib, jeff.Feb 23 2018, 5:13 PM

Hmm, should we queue wired page into laundry at all ?

In D14485#303755, @kib wrote:

Hmm, should we queue wired page into laundry at all ?

Sorry, I don't follow. Here we only queue the page if it isn't wired. If it's wired, there's no point in enqueuing it since the unwiring thread will either enqueue it or ensure that it is not enqueued anywhere.

Yes, it was the bad question. I mean, should we leave the page queued if it is wired and vm_page_launder() is called on it.

In D14485#303890, @kib wrote:

Yes, it was the bad question. I mean, should we leave the page queued if it is wired and vm_page_launder() is called on it.

I don't see any reason to bother dequeuing: we'd need to acquire the page queue lock, and one of the motivations for r328977 was to avoid that lock when it is not needed.

kib accepted this revision.Feb 23 2018, 10:21 PM

This revision is now accepted and ready to land.Feb 23 2018, 10:21 PM

Closed by commit rS329885: Remove a bogus assertion from vm_page_launder(). (authored by markj). · Explain WhyFeb 23 2018, 11:25 PM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptFeb 23 2018, 11:25 PM