Page MenuHomeFreeBSD

dhclient: raise WARNS to 4
ClosedPublic

Authored by asomers on Feb 21 2018, 6:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 30, 11:40 AM
Unknown Object (File)
Mar 12 2024, 12:38 AM
Unknown Object (File)
Mar 12 2024, 12:38 AM
Unknown Object (File)
Mar 12 2024, 12:35 AM
Unknown Object (File)
Mar 8 2024, 4:05 AM
Unknown Object (File)
Feb 22 2024, 6:47 AM
Unknown Object (File)
Jan 13 2024, 3:28 AM
Unknown Object (File)
Jan 5 2024, 3:35 AM
Subscribers

Details

Summary

dhclient: raise WARNS to 4

Mostly const-correctness fixes. There were also some variable-shadowing,
unused variable, and a couple of sockaddr type-correctness changes. I also had
trouble with cast-align warnings. I was able to prove that one of them was a
false positive. But ultimately I had to disable the warning program-wide to
deal with the others.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 15187
Build 15262: arc lint + arc unit

Event Timeline

Looks good. Two questions below

sbin/dhclient/dispatch.c
106

Should this be the _Alignof the pointer type or the struct type?

109

Is this needed with the NO_WCAST_ALIGN Makefile variable?

This revision is now accepted and ready to land.Feb 21 2018, 8:36 PM
sbin/dhclient/dispatch.c
106

Good catch.

109

Technically no. But it will be needed if anybody ever reenables WCAST_ALIGN and fixes the other violations.

This revision was automatically updated to reflect the committed changes.