dhclient: raise WARNS to 4
ClosedPublic

Authored by asomers on Feb 21 2018, 6:12 PM.

Details

Summary

dhclient: raise WARNS to 4

Mostly const-correctness fixes. There were also some variable-shadowing,
unused variable, and a couple of sockaddr type-correctness changes. I also had
trouble with cast-align warnings. I was able to prove that one of them was a
false positive. But ultimately I had to disable the warning program-wide to
deal with the others.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
asomers created this revision.Feb 21 2018, 6:12 PM
cem accepted this revision.Feb 21 2018, 8:36 PM

Looks good. Two questions below

sbin/dhclient/dispatch.c
106 ↗(On Diff #39574)

Should this be the _Alignof the pointer type or the struct type?

109 ↗(On Diff #39574)

Is this needed with the NO_WCAST_ALIGN Makefile variable?

This revision is now accepted and ready to land.Feb 21 2018, 8:36 PM
asomers added inline comments.Feb 21 2018, 9:09 PM
sbin/dhclient/dispatch.c
106 ↗(On Diff #39574)

Good catch.

109 ↗(On Diff #39574)

Technically no. But it will be needed if anybody ever reenables WCAST_ALIGN and fixes the other violations.

Closed by commit rS329754: dhclient: raise WARNS to 4 (authored by asomers, committed by ). · Explain WhyFeb 21 2018, 9:13 PM
This revision was automatically updated to reflect the committed changes.