Tags

None

Referenced Files

	F82778661: D14338.id.diff
	Thu, May 2, 1:03 PM

	F82777742: D14338.id87353.diff
	Thu, May 2, 12:53 PM

	F82770535: D14338.id90608.diff
	Thu, May 2, 11:11 AM

	F82770478: D14338.id87155.diff
	Thu, May 2, 11:10 AM

	F82770466: D14338.id87352.diff
	Thu, May 2, 11:10 AM

	F82770423: D14338.id39226.diff
	Thu, May 2, 11:10 AM

	Unknown Object (File)
	Thu, May 2, 9:46 AM

	Unknown Object (File)
	Mon, Apr 29, 7:24 AM

Subscribers

Details

Reviewers

mjg

Summary

pmc(3) is a longstanding FreeBSD feature. Without a reserved syscall it
is impractical to implement freebsd32 compatability, syscall wrappers of
any sort, or to support calling conventions that require knowledge of
the types of syscall arguments.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 38550
Build 35439: arc lint + arc unit

Event Timeline

brooks created this revision.Feb 12 2018, 10:51 PM

Harbormaster completed remote builds in B14991: Diff 39226.Feb 12 2018, 10:51 PM

Rebase

Herald added a subscriber: imp. · View Herald TranscriptApr 9 2021, 9:16 PM

Harbormaster completed remote builds in B38472: Diff 87155.Apr 9 2021, 9:17 PM

Rename syscall to pmc_op
libpmc: Call pmc_op directly

Harbormaster completed remote builds in B38549: Diff 87352.Apr 12 2021, 11:23 PM

pmc_op: Add freebsd32 stub

Harbormaster completed remote builds in B38550: Diff 87353.Apr 12 2021, 11:40 PM

rebase, regen generated files

Harbormaster completed remote builds in B39815: Diff 90608.Jun 8 2021, 10:05 PM

brooks retitled this revision from Register a syscall for pmc(4). to Register a syscall for pmc(3)..Jun 9 2021, 4:13 PM

brooks edited the summary of this revision. (Show Details)

thank you

This revision is now accepted and ready to land.Apr 19 2023, 6:52 PM

mjg added inline comments.Apr 19 2023, 6:53 PM

lib/libpmc/libpmc.c
1386–1387	this block is of no significance now?

emaste added a subscriber: emaste.Nov 15 2023, 6:28 PM

Register a syscall for pmc(3).
AcceptedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 87353

lib/libc/sys/Symbol.map

lib/libpmc/libpmc.c

sys/compat/freebsd32/freebsd32_syscall.h

sys/compat/freebsd32/freebsd32_syscalls.c

sys/compat/freebsd32/freebsd32_sysent.c

sys/compat/freebsd32/syscalls.master

sys/dev/hwpmc/hwpmc_mod.c

sys/kern/init_sysent.c

sys/kern/syscalls.c

sys/kern/syscalls.master

sys/kern/systrace_args.c

sys/sys/pmc.h

sys/sys/syscall.h

sys/sys/syscall.mk

sys/sys/sysproto.h

Register a syscall for pmc(3).AcceptedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 87353

lib/libc/sys/Symbol.map

lib/libpmc/libpmc.c

sys/compat/freebsd32/freebsd32_syscall.h

sys/compat/freebsd32/freebsd32_syscalls.c

sys/compat/freebsd32/freebsd32_sysent.c

sys/compat/freebsd32/syscalls.master

sys/dev/hwpmc/hwpmc_mod.c

sys/kern/init_sysent.c

sys/kern/syscalls.c

sys/kern/syscalls.master

sys/kern/systrace_args.c

sys/sys/pmc.h

sys/sys/syscall.h

sys/sys/syscall.mk

sys/sys/sysproto.h

Register a syscall for pmc(3).
AcceptedPublic
Actions

Revision Contents
Changeset List