Page MenuHomeFreeBSD
Differential D14336

Precisions/caveat for 30.8 Diskless Operation
ClosedPublic
Actions

Authored by rodrigo on Feb 12 2018, 8:37 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 6, 6:47 AM
Unknown Object (File)
Thu, Nov 6, 4:57 AM
Unknown Object (File)
Thu, Nov 6, 4:57 AM
Unknown Object (File)
Thu, Nov 6, 4:57 AM
Unknown Object (File)
Thu, Nov 6, 4:56 AM
Unknown Object (File)
Thu, Nov 6, 4:56 AM
Unknown Object (File)
Thu, Nov 6, 3:04 AM
Unknown Object (File)
Sun, Oct 26, 3:56 AM
View All Files
Subscribers
adridg
brd
• ian

Details

Reviewers
allanjude
dru
sevan
bcr
• ian
Commits
rD51461: update/correct the Handbook Diskless operations chapter
Summary

Review for PR 213175

Diff Detail

Repository
rD FreeBSD doc repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

rodrigo created this revision.Feb 12 2018, 8:37 PM
Harbormaster completed remote builds in B14985: Diff 39220.Feb 12 2018, 8:37 PM
rodrigo edited the summary of this revision. (Show Details)Feb 13 2018, 12:39 PM
rodrigo abandoned this revision.Feb 14 2018, 11:12 PM
rodrigo added reviewers: allanjude, dru, sevan.
rodrigo reclaimed this revision.Feb 14 2018, 11:16 PM

wrong action

lme added a reviewer: bcr.Feb 15 2018, 9:52 AM
adridg added a subscriber: adridg.Feb 15 2018, 10:10 AM
adridg added inline comments.
en_US.ISO8859-1/books/handbook/advanced-networking/chapter.xml
3946 ↗(On Diff #39220)

Although *make* is the command, logically *make install* is the command-to-which-you-add-DESTDIR; I would move the *install* inside <command>.

4023 ↗(On Diff #39220)

putting *the number of 512 byte sectors needed (e.g. 5 megabytes is 10240 sectors)* in

Scans better for me and includes an example.

bcr added a comment.Feb 15 2018, 12:27 PM

I found a superfluous space (in addition to what @adridg has found.
Try checking it with textproc/igor, there might be additional output/suggestions.

en_US.ISO8859-1/books/handbook/advanced-networking/chapter.xml
4023 ↗(On Diff #39220)

no space before the comma

• ian added a subscriber: • ian.Feb 15 2018, 4:18 PM
• ian added inline comments.
en_US.ISO8859-1/books/handbook/advanced-networking/chapter.xml
3946 ↗(On Diff #39220)

No, "make install" is not literally the command; "make installworld", "make installkernel", and "make distribution" are, collectively, "the make install commands".

brd added a subscriber: brd.Feb 15 2018, 4:19 PM
rodrigo added inline comments.Feb 19 2018, 8:17 AM
en_US.ISO8859-1/books/handbook/advanced-networking/chapter.xml
3946 ↗(On Diff #39220)

@ian, does something like this sounds better ?
(I split it in several lines intentionally to make it more readable)

but do not forget to add 
<option>DESTDIR=<replaceable>${NFSROOTDOR} </replaceable></option>
when running the 
<command>make installkernel</command>
and 
<command>make installworld</command> 
commands.
bcr added a comment.Feb 19 2018, 9:37 AM

I found a typo...

en_US.ISO8859-1/books/handbook/advanced-networking/chapter.xml
3946 ↗(On Diff #39220)

s/NFSROOTDOR/NFSROOTDIR/

;-)

rodrigo updated this revision to Diff 39545.Feb 20 2018, 11:58 PM

Fix reported issues and make igor happy as much as possible

Harbormaster completed remote builds in B15173: Diff 39545.Feb 20 2018, 11:58 PM
rodrigo marked 6 inline comments as done.Feb 20 2018, 11:59 PM
• ian accepted this revision.Mar 2 2018, 11:03 PM
• ian added inline comments.
en_US.ISO8859-1/books/handbook/advanced-networking/chapter.xml
3946 ↗(On Diff #39220)

Yes, that's good.

This revision is now accepted and ready to land.Mar 2 2018, 11:03 PM
rodrigo marked an inline comment as done.Mar 3 2018, 11:15 AM
rodrigo added a comment.Mar 4 2018, 5:02 PM

@bcr, @sevan : a formal approval from a doc committer would be appreciated.

sevan added inline comments.Mar 4 2018, 5:13 PM
en_US.ISO8859-1/books/handbook/advanced-networking/chapter.xml
2522 ↗(On Diff #39545)

No objection to the changes, just one minor nit.
Does the actual command output state "doesn't" or has the text outputs since been changed?

rodrigo updated this revision to Diff 39948.Mar 5 2018, 1:51 AM

Remove unwanted change

This revision now requires review to proceed.Mar 5 2018, 1:51 AM
Harbormaster completed remote builds in B15369: Diff 39948.Mar 5 2018, 1:51 AM
rodrigo marked an inline comment as done.Mar 5 2018, 1:53 AM
rodrigo added inline comments.
en_US.ISO8859-1/books/handbook/advanced-networking/chapter.xml
2522 ↗(On Diff #39545)

You're completely right, this is an unwanted change.

rodrigo marked 2 inline comments as done.Mar 5 2018, 1:53 AM
sevan accepted this revision.Mar 5 2018, 1:57 AM
This revision is now accepted and ready to land.Mar 5 2018, 1:57 AM
Closed by commit rD51461: update/correct the Handbook Diskless operations chapter (authored by rodrigo). · Explain WhyMar 5 2018, 3:51 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
en_US.ISO8859-1/
books/
handbook/
advanced-networking/
39 lines

Diff 39958

View Options

head/en_US.ISO8859-1/books/handbook/advanced-networking/chapter.xml

Loading...