New port: www/go-appengine-sdk: App Engine SDK for Go

[yuri]

Summary

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=225826

[mat]

www/go-appengine-sdk/Makefile

45–51

GOARCH=  ${ARCH:S/i386/386}

53–55

GO387_VARS= GO386=387

[dmgk]

www/go-appengine-sdk/Makefile

45–51

Thanks. I just realised that there's no need for IGNORE because of ONLY_FOR_ARCHS above.

[dmgk]

Simplify GOARCH and GO386 options.

[sunpoet]

www/go-appengine-sdk/Makefile

7

Use DISTNAME and USES=zip.

12–13

Please update LICENSE and add LICENSE_FILE.

Since you did not install the whole zip file, you do not need to list all licenses mentioned in ${WRKSRC}/LICENSE.
Please set LICENSE to the licenses of installed items.

[mat]

www/go-appengine-sdk/Makefile

73

I am not sure what is being CP'ed here, but never use cp to install files, use COPYTREE_SHARE/BIN or one of the INSTALL_* macros.

[dmgk]

Address review feedback.

[dmgk]

www/go-appengine-sdk/Makefile

12–13

We do install the while zip file (apart from a few Linux binary artifacts and PHP stuff that doesn't have a separate license) so all licenses listed in LICENSE_FILE apply.

73

This ports rebuilds two Go distributions (1.6 and 1.8) included in the upstream zip to get native FreeBSD binaries and installs resulting GOROOTs with ${CP}, I stole this CP line from lang/go. While it probably would be possible to get the same result with a combination of COPYTREE_SHARE/BIN, it would make do-install much more complex because there's a bunch of executables and .pl/.sh scripts scattered through GOROOT subfolders.

[dmgk]

www/go-appengine-sdk/Makefile

21

Maybe we need something like LICENSE_FILE_combo for cases when all licenses are lumped together in a single file.

[yuri]

.

[dmgk]

www/go-appengine-sdk/Makefile

83

That would remove executable bit from all binaries, no?

[yuri]

.

[tcberner]

From my side it looks good.

[sunpoet]

head/www/go-appengine-sdk/Makefile

12–20 ↗

(On Diff #39446)

(1)
For me, I would not set LICENSE_FILE for a license without full text in the file.

Though 7 licenses are mentioned in ${WRKSRC}/LICENSE, it only has full text of 2 licenses (BSD3CLAUSE and MIT).

That means I would only set LICNESE_FILE_BSD3CLAUSE and LICENSE_FILE_MIT.

If you think ${WRKSRC}/LICENSE contains 7 licenses, then LICENSE_FILE=${WRKSRC}/LICENSE is fine (support added in r451432).

(2)
Regarding GPLv2, LGPL21 and MPL11, I guess you add them because of cacerts.
GPLv2 and LGPL21 should be change to GPLv2+ and LGPL21+.
The correct license for this port is "APACHE20 and BSD3CLAUSE and MIT and PSFL and (GPLv2+ or LGPL21+ or MPL11)".
Since our LICENSE framework does not support the case of "A and B and C and D and (E or F or G)", it will be better to add a comment.

from LICENSE:

cacerts

Version: MPL 1.1/GPL 2.0/LGPL 2.1
<snip>
Alternatively, the contents of this file may be used under the terms of
either the GNU General Public License Version 2 or later (the "GPL"), or
the GNU Lesser General Public License Version 2.1 or later (the "LGPL"),

70 ↗

(On Diff #39446)

Use ${PYTHON_CMD} instead of "{LOCALBASE}/bin/python2.7".

[yuri]

head/www/go-appengine-sdk/Makefile

12–20 ↗

(On Diff #39446)

Sunpoet,

Thank you for this information.
I will update the port.

Yuri