Details
- Reviewers
tcberner adamw - Commits
- rP462196: New port: www/go-appengine-sdk: App Engine SDK for Go
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
www/go-appengine-sdk/Makefile | ||
---|---|---|
44–50 ↗ | (On Diff #39181) | Thanks. I just realised that there's no need for IGNORE because of ONLY_FOR_ARCHS above. |
www/go-appengine-sdk/Makefile | ||
---|---|---|
7 ↗ | (On Diff #39207) | Use DISTNAME and USES=zip. |
12–13 ↗ | (On Diff #39207) | Please update LICENSE and add LICENSE_FILE. Since you did not install the whole zip file, you do not need to list all licenses mentioned in ${WRKSRC}/LICENSE. |
www/go-appengine-sdk/Makefile | ||
---|---|---|
73 ↗ | (On Diff #39207) | I am not sure what is being CP'ed here, but never use cp to install files, use COPYTREE_SHARE/BIN or one of the INSTALL_* macros. |
www/go-appengine-sdk/Makefile | ||
---|---|---|
12–13 ↗ | (On Diff #39207) | We do install the while zip file (apart from a few Linux binary artifacts and PHP stuff that doesn't have a separate license) so all licenses listed in LICENSE_FILE apply. |
73 ↗ | (On Diff #39207) | This ports rebuilds two Go distributions (1.6 and 1.8) included in the upstream zip to get native FreeBSD binaries and installs resulting GOROOTs with ${CP}, I stole this CP line from lang/go. While it probably would be possible to get the same result with a combination of COPYTREE_SHARE/BIN, it would make do-install much more complex because there's a bunch of executables and .pl/.sh scripts scattered through GOROOT subfolders. |
www/go-appengine-sdk/Makefile | ||
---|---|---|
20 ↗ | (On Diff #39223) | Maybe we need something like LICENSE_FILE_combo for cases when all licenses are lumped together in a single file. |
www/go-appengine-sdk/Makefile | ||
---|---|---|
82 ↗ | (On Diff #39406) | That would remove executable bit from all binaries, no? |
head/www/go-appengine-sdk/Makefile | ||
---|---|---|
12–20 | (1) Though 7 licenses are mentioned in ${WRKSRC}/LICENSE, it only has full text of 2 licenses (BSD3CLAUSE and MIT). That means I would only set LICNESE_FILE_BSD3CLAUSE and LICENSE_FILE_MIT. If you think ${WRKSRC}/LICENSE contains 7 licenses, then LICENSE_FILE=${WRKSRC}/LICENSE is fine (support added in r451432). (2) from LICENSE:
| |
70 | Use ${PYTHON_CMD} instead of "{LOCALBASE}/bin/python2.7". |
head/www/go-appengine-sdk/Makefile | ||
---|---|---|
12–20 | Sunpoet, Thank you for this information. Yuri |