Details
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| sys/sys/msg.h | ||
|---|---|---|
| 130 ↗ | (On Diff #39058) | I would perhaps use slightly-less fine-grained macros. E.g. a single _WANT_SYSVMSG for this file. |
| sys/sys/msg.h | ||
|---|---|---|
| 154 ↗ | (On Diff #39222) | You can drop this and the above #endif now I think? |
| 174 ↗ | (On Diff #39222) | Maybe blank lines around the #else as there is in sem.h (and then keep the blank line before the #endif)? I find that a bit easier to read. |
| sys/sys/sem.h | ||
| 124 ↗ | (On Diff #39222) | Here as well. |
| 135 ↗ | (On Diff #39222) | Here. |
| sys/sys/shm.h | ||
| 127 ↗ | (On Diff #39222) | Can collapse this #endif and #if. |
| 133 ↗ | (On Diff #39222) | I think for this I would actually prefer to always use the 'struct vm_object;' forward declare and then use 'struct vm_object *' instead of 'vm_object_t'. I feel like we do this in some other places in the kernel where we export a structure to userland, e.g. for 'td_kstack_obj' in 'struct thread'. That would mean you wouldn't need the #include of <vm/vm.h> or the #ifdef at all. |
| usr.bin/ipcs/ipc.h | ||
| 71 ↗ | (On Diff #39222) | Oh wow, that was gross (ipcs depending on the kernel externs) |