Page MenuHomeFreeBSD
Differential D14228

bsd.linker.mk: add retpolineplt linker feature
ClosedPublic
Actions

Authored by emaste on Feb 6 2018, 8:09 PM.
Tags
None
Referenced Files
F108016568: D14228.id38977.diff
Mon, Jan 20, 1:52 PM
Unknown Object (File)
Fri, Jan 17, 12:06 PM
Unknown Object (File)
Tue, Dec 31, 3:41 PM
Unknown Object (File)
Tue, Dec 31, 2:44 AM
Unknown Object (File)
Dec 13 2024, 1:24 PM
Unknown Object (File)
Dec 12 2024, 11:27 AM
Unknown Object (File)
Nov 25 2024, 8:31 PM
Unknown Object (File)
Nov 25 2024, 1:32 AM
View All Files
Subscribers
dim
imp
lattera-gmail.com

Details

Reviewers
bdrewery
imp
Commits
rS328972: add retpoline compiler and linker feature flags
Summary

This feature indicates that the linker supports generating a PLT with the retpoline speculative execution vulnerability mitigation.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

emaste created this revision.Feb 6 2018, 8:09 PM
emaste updated this revision to Diff 38967.Feb 6 2018, 8:18 PM

Include COMPILER_FEATURES

emaste updated this revision to Diff 38977.Feb 6 2018, 10:36 PM
emaste added subscribers: imp, dim.

Quote COMPILER_FEATURES for CROSSENV as it may contain spaces

dim added a comment.Feb 6 2018, 10:41 PM

This looks good to me, though at some version gcc and BFD ld will also support retpoline, right? We can add that later...

imp accepted this revision.Feb 6 2018, 11:03 PM

One minor quibble.

share/mk/bsd.linker.mk
76 ↗(On Diff #38977)

Are there places that LINKER_FEATURES need similar treatment?

This revision is now accepted and ready to land.Feb 6 2018, 11:03 PM
emaste added a comment.Feb 7 2018, 1:08 AM
In D14228#298494, @dim wrote:

This looks good to me, though at some version gcc and BFD ld will also support retpoline, right? We can add that later...

Yes. Once the support appears in our gcc and binutils ports and we know the version we can add it.

share/mk/bsd.linker.mk
76 ↗(On Diff #38977)

I did not find cases where LINKER_FEATURES is passed through the environment

Closed by commit rS328972: add retpoline compiler and linker feature flags (authored by emaste). · Explain WhyFeb 7 2018, 2:50 PM
This revision was automatically updated to reflect the committed changes.
emaste marked 2 inline comments as done.Feb 7 2018, 2:50 PM

Revision Contents
Changeset List

PathSize
head/
4 lines
share/
mk/
12 lines
7 lines

Diff 38998

View Options

head/Makefile.inc1

Loading...
View Options

head/share/mk/bsd.compiler.mk

Loading...
View Options

head/share/mk/bsd.linker.mk

Loading...