Page MenuHomeFreeBSD

databases/sqlite3: Update to 3.22.0
ClosedPublic

Authored by yuri on Feb 5 2018, 9:38 PM.

Details

Summary

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=225627 (maintainer approval is present)

I verified it on 11.1 amd64 and 10.3 i386.
Since this is a very common port with a lot of dependencies, is ExpRun needed? IMO, ExpRun is a good idea.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

yuri created this revision.Feb 5 2018, 9:38 PM
adamw added a comment.Feb 5 2018, 10:46 PM

sqlite updates don't usually need an exp-run. The upstream regression tests are comprehensive and there are almost never breaking changes. I think your gut instinct is good---normally a port this important should have an exp-run. sqlite is generally pretty safe though.

When you do commit this (let's fix up the new _DESC first though), be sure to explain in the commit message why those two other options are being removed.

databases/sqlite3/Makefile
47 ↗(On Diff #38912)

This description needs to be improved. It doesn't say much to the end-users themselves. Can you make it more useful?

yuri added a comment.Feb 5 2018, 11:36 PM

sqlite is generally pretty safe though.

Yes, they have a reputation of a rock-solid code delivered by one pretty based developer. :-)

yuri updated this revision to Diff 38917.Feb 5 2018, 11:44 PM
yuri marked an inline comment as done.

Improved the description of the OFFSET option.

yuri added inline comments.Feb 5 2018, 11:46 PM
databases/sqlite3/Makefile
47 ↗(On Diff #38912)

This appears to be a new feature that they keep disabled by default for now.

yuri marked an inline comment as done.Feb 5 2018, 11:52 PM
adamw accepted this revision.Feb 6 2018, 12:00 AM

Before committing, please make sure that it passes portlint (I don't know if there's an option _DESC length max) and that the whole message is viewable. If not please shorten it however you see fit.

This revision is now accepted and ready to land.Feb 6 2018, 12:00 AM
yuri added a comment.Feb 6 2018, 12:51 AM

Before committing, please make sure that it passes portlint (I don't know if there's an option _DESC length max) and that the whole message is viewable. If not please shorten it however you see fit.

It fits, I verified.


Concerning option deletions, I will take some time to see if deletion is reasonable. Will also compare the list of project build options with the list of port options.

This revision was automatically updated to reflect the committed changes.