https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=225627 (maintainer approval is present)
I verified it on 11.1 amd64 and 10.3 i386.
Since this is a very common port with a lot of dependencies, is ExpRun needed? IMO, ExpRun is a good idea.
Details
Details
- Reviewers
tcberner adamw - Commits
- rP464472: databases/sqlite: Update to 3.22.0
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
sqlite updates don't usually need an exp-run. The upstream regression tests are comprehensive and there are almost never breaking changes. I think your gut instinct is good---normally a port this important should have an exp-run. sqlite is generally pretty safe though.
When you do commit this (let's fix up the new _DESC first though), be sure to explain in the commit message why those two other options are being removed.
| databases/sqlite3/Makefile | ||
|---|---|---|
| 47 ↗ | (On Diff #38912) | This description needs to be improved. It doesn't say much to the end-users themselves. Can you make it more useful? |
Comment Actions
Yes, they have a reputation of a rock-solid code delivered by one pretty based developer. :-)
| databases/sqlite3/Makefile | ||
|---|---|---|
| 47 ↗ | (On Diff #38912) | This appears to be a new feature that they keep disabled by default for now. |
Comment Actions
Before committing, please make sure that it passes portlint (I don't know if there's an option _DESC length max) and that the whole message is viewable. If not please shorten it however you see fit.
Comment Actions
It fits, I verified.
Concerning option deletions, I will take some time to see if deletion is reasonable. Will also compare the list of project build options with the list of port options.