lang/hugs: Workaround 12-CURRENT fallout
ClosedPublic
Actions

Authored by arrowd on Feb 3 2018, 8:07 PM.

Details

Reviewers

None

Group Reviewers

Contributor Reviewers (ports)

Commits

rP463193: devel/hugs: workaround to fix build on current

Summary

runhugs binary crashes when compiled with -O2 on i386 12-CURRENT system. Workaround it by compiling with -O0.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

arrowd created this revision.Feb 3 2018, 8:07 PM

Herald added subscribers: Contributor Reviewers (ports), mat. · View Herald TranscriptFeb 3 2018, 8:07 PM

arrowd added a reviewer: Contributor Reviewers (ports).Feb 3 2018, 8:08 PM

swills added a subscriber: swills.Feb 5 2018, 7:46 PM

swills added inline comments.

lang/hugs/Makefile
28 ↗	(On Diff #38824)	If this is only needed on 12-CURRENT then check `OSVERSION > 1200056` or whatever as well.

mat added inline comments.Feb 5 2018, 10:55 PM

lang/hugs/Makefile
26 ↗	(On Diff #38824)	ARCH is not defined at that point of the Makefile.

Constrain workaround to FreeBSD 12 only.

Harbormaster completed remote builds in B14816: Diff 38956.Feb 6 2018, 6:55 PM

arrowd marked an inline comment as done.Feb 6 2018, 6:55 PM

arrowd added inline comments.

lang/hugs/Makefile
26 ↗	(On Diff #38824)	Hum, it worked for me as it is. Should I include `<bsd.options.mk>` then, or something else?

Include bsd.port.pre.mk to be able to use ${ARCH}

Harbormaster completed remote builds in B15261: Diff 39715.Feb 25 2018, 7:37 PM

arrowd marked an inline comment as done.Feb 25 2018, 7:37 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 28 2018, 10:54 AM

Closed by commit rP463193: devel/hugs: workaround to fix build on current (authored by tcberner). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

lang/

hugs/

Makefile

8 lines

Diff 39821

View Options

lang/hugs: Workaround 12-CURRENT falloutClosedPublicActions