Page MenuHomeFreeBSD

makesyscalls: permit a range of syscall numbers for UNIMPL
ClosedPublic

Authored by emaste on Jan 29 2018, 7:09 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 27, 1:22 PM
Unknown Object (File)
Tue, Apr 22, 6:29 PM
Unknown Object (File)
Tue, Apr 15, 5:52 AM
Unknown Object (File)
Mar 17 2025, 9:13 AM
Unknown Object (File)
Mar 1 2025, 3:16 PM
Unknown Object (File)
Feb 28 2025, 10:11 PM
Unknown Object (File)
Feb 16 2025, 6:06 PM
Unknown Object (File)
Jan 30 2025, 12:12 PM
Subscribers

Details

Summary

Some ABIs have large gaps in syscall numbers. Allow gaps to be filled as ranges of UNIMPL, with an entry like:

248-1023        AUE_NULL        UNIMPL  dummy

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

In general I like the approach. It's easy enough to extend to other keywords in the future if needed as well.

sys/kern/makesyscalls.sh
630 ↗(On Diff #38638)

I guess it isn't obvious to me that syscall_range[2] would always be valid. Does awk return '0' for out-of-range array access? Hmm, seems like it returns the empty string probably from the manpage. I wonder if it would be cleaner to explicitly set syscall_range[2] to syscall in the 'n ==1' case and then this loop could just be 'while (syscall <= syscall_range[2])'?

This revision is now accepted and ready to land.Jan 30 2018, 1:20 AM

Always set syscall_range[2] as suggested by jhb

This revision now requires review to proceed.Jan 30 2018, 2:00 AM
This revision is now accepted and ready to land.Jan 30 2018, 6:16 PM
This revision was automatically updated to reflect the committed changes.