Page MenuHomeFreeBSD

makesyscalls: permit a range of syscall numbers for UNIMPL
ClosedPublic

Authored by emaste on Jan 29 2018, 7:09 PM.
Tags
None
Referenced Files
F163931175: D14122.id38657.diff
Mon, Jul 27, 6:38 AM
Unknown Object (File)
Sat, Jul 25, 3:25 PM
Unknown Object (File)
Jun 20 2026, 2:42 PM
Unknown Object (File)
Jun 16 2026, 12:54 PM
Unknown Object (File)
Jun 16 2026, 8:28 AM
Unknown Object (File)
Jun 15 2026, 8:31 PM
Unknown Object (File)
Jun 14 2026, 11:59 PM
Unknown Object (File)
Jun 6 2026, 10:17 AM
Subscribers

Details

Summary

Some ABIs have large gaps in syscall numbers. Allow gaps to be filled as ranges of UNIMPL, with an entry like:

248-1023        AUE_NULL        UNIMPL  dummy

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

In general I like the approach. It's easy enough to extend to other keywords in the future if needed as well.

sys/kern/makesyscalls.sh
630 ↗(On Diff #38638)

I guess it isn't obvious to me that syscall_range[2] would always be valid. Does awk return '0' for out-of-range array access? Hmm, seems like it returns the empty string probably from the manpage. I wonder if it would be cleaner to explicitly set syscall_range[2] to syscall in the 'n ==1' case and then this loop could just be 'while (syscall <= syscall_range[2])'?

This revision is now accepted and ready to land.Jan 30 2018, 1:20 AM

Always set syscall_range[2] as suggested by jhb

This revision now requires review to proceed.Jan 30 2018, 2:00 AM
This revision is now accepted and ready to land.Jan 30 2018, 6:16 PM
This revision was automatically updated to reflect the committed changes.