pfctl(8): Fix two wrong conditions.
ClosedPublic
Actions

Authored by pfg on Jan 27 2018, 10:34 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, May 3, 5:33 AM

	Unknown Object (File)
	Fri, May 3, 5:29 AM

	Unknown Object (File)
	Fri, May 3, 5:29 AM

	Unknown Object (File)
	Thu, May 2, 11:27 PM

	Unknown Object (File)
	Sat, Apr 20, 1:17 AM

	Unknown Object (File)
	Feb 1 2024, 4:40 PM

	Unknown Object (File)
	Dec 22 2023, 10:09 PM

	Unknown Object (File)
	Nov 12 2023, 10:41 AM

View All 31 Files

Subscribers

imp

Details

Reviewers

kp
glebius

Commits

rS328497: pfctl(8): Fix two wrong conditions.

Summary

Caught by gcc80's -Wtautological-compare option.

Obtained from: DragonFlyBSD (git e3cdbf6c)

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 14615
Build 14747: arc lint + arc unit

Event Timeline

pfg created this revision.Jan 27 2018, 10:34 PM

Herald added a subscriber: imp. · View Herald TranscriptJan 27 2018, 10:34 PM

Good catch.

This revision is now accepted and ready to land.Jan 27 2018, 10:46 PM

Closed by commit rS328497: pfctl(8): Fix two wrong conditions. (authored by pfg). · Explain WhyJan 27 2018, 10:57 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sbin/

pfctl/

pfctl_optimize.c

4 lines

Diff 38549

View Options

sbin/pfctl/pfctl_optimize.c

pfctl(8): Fix two wrong conditions.ClosedPublicActions