Page MenuHomeFreeBSD
Differential D14083

pfctl(8): Fix two wrong conditions.
ClosedPublic
Actions

Authored by pfg on Jan 27 2018, 10:34 PM.
Tags
None
Referenced Files
F110437957: D14083.diff
Tue, Feb 18, 11:37 AM
Unknown Object (File)
Tue, Feb 11, 9:26 PM
Unknown Object (File)
Jan 13 2025, 3:59 PM
Unknown Object (File)
Jan 3 2025, 11:25 AM
Unknown Object (File)
Sep 29 2024, 5:18 PM
Unknown Object (File)
Sep 21 2024, 3:43 AM
Unknown Object (File)
Sep 16 2024, 11:53 PM
Unknown Object (File)
Sep 16 2024, 7:55 AM
View All 46 Files
Subscribers
imp

Details

Reviewers
kp
glebius
Commits
rS328497: pfctl(8): Fix two wrong conditions.
Summary

Caught by gcc80's -Wtautological-compare option.

Obtained from: DragonFlyBSD (git e3cdbf6c)

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 14615
Build 14747: arc lint + arc unit

Event Timeline

pfg created this revision.Jan 27 2018, 10:34 PM
Herald added a subscriber: imp. · View Herald TranscriptJan 27 2018, 10:34 PM
kp accepted this revision.Jan 27 2018, 10:46 PM

Good catch.

This revision is now accepted and ready to land.Jan 27 2018, 10:46 PM
Closed by commit rS328497: pfctl(8): Fix two wrong conditions. (authored by pfg). · Explain WhyJan 27 2018, 10:57 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sbin/
pfctl/
4 lines

Diff 38549

View Options

sbin/pfctl/pfctl_optimize.c

Loading...