Page MenuHomeFreeBSD
Differential D14083

pfctl(8): Fix two wrong conditions.
ClosedPublic
Actions

Authored by pfg on Jan 27 2018, 10:34 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Sep 19, 6:37 AM
Unknown Object (File)
Sep 3 2025, 2:10 PM
Unknown Object (File)
Aug 29 2025, 4:29 PM
Unknown Object (File)
Aug 15 2025, 3:48 PM
Unknown Object (File)
Jul 8 2025, 7:57 PM
Unknown Object (File)
Jul 7 2025, 3:16 PM
Unknown Object (File)
Jul 7 2025, 3:34 AM
Unknown Object (File)
Jul 5 2025, 4:42 PM
View All 75 Files
Subscribers
imp

Details

Reviewers
kp
glebius
Commits
rS328497: pfctl(8): Fix two wrong conditions.
Summary

Caught by gcc80's -Wtautological-compare option.

Obtained from: DragonFlyBSD (git e3cdbf6c)

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

pfg created this revision.Jan 27 2018, 10:34 PM
Herald added a subscriber: imp. · View Herald TranscriptJan 27 2018, 10:34 PM
kp accepted this revision.Jan 27 2018, 10:46 PM

Good catch.

This revision is now accepted and ready to land.Jan 27 2018, 10:46 PM
Closed by commit rS328497: pfctl(8): Fix two wrong conditions. (authored by pfg). · Explain WhyJan 27 2018, 10:57 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sbin/
pfctl/
4 lines

Diff 38551

View Options

head/sbin/pfctl/pfctl_optimize.c

Loading...