pfctl(8): Fix two wrong conditions.
ClosedPublic
Actions

Authored by pfg on Jan 27 2018, 10:34 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Apr 16, 4:01 PM

	Unknown Object (File)
	Tue, Apr 7, 3:05 PM

	Unknown Object (File)
	Mon, Apr 6, 8:56 AM

	Unknown Object (File)
	Thu, Apr 2, 6:58 AM

	Unknown Object (File)
	Thu, Mar 26, 12:30 AM

	Unknown Object (File)
	Wed, Mar 25, 7:57 PM

	Unknown Object (File)
	Tue, Mar 24, 8:06 PM

	Unknown Object (File)
	Mar 16 2026, 1:26 PM

View All Files

Subscribers

imp

Details

Reviewers

kp
glebius

Commits

rS328497: pfctl(8): Fix two wrong conditions.

Summary

Caught by gcc80's -Wtautological-compare option.

Obtained from: DragonFlyBSD (git e3cdbf6c)

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

pfg created this revision.Jan 27 2018, 10:34 PM

Herald added a subscriber: imp. · View Herald TranscriptJan 27 2018, 10:34 PM

Good catch.

This revision is now accepted and ready to land.Jan 27 2018, 10:46 PM

Closed by commit rS328497: pfctl(8): Fix two wrong conditions. (authored by pfg). · Explain WhyJan 27 2018, 10:57 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sbin/

pfctl/

pfctl_optimize.c

4 lines

Diff 38551

View Options

head/sbin/pfctl/pfctl_optimize.c

pfctl(8): Fix two wrong conditions.ClosedPublicActions