Page MenuHomeFreeBSD

Update FreeBSD versions referenced in Poudriere docs...
ClosedPublic

Authored by seanc on Jan 27 2018, 6:53 AM.

Details

Summary

The Porters Handbook listed out of date versions of FreeBSD. Update to match current releases, including a hat-tip to porters running -CURRENT.

Diff Detail

Repository
rD FreeBSD doc repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

seanc created this revision.Jan 27 2018, 6:53 AM
seanc updated this revision to Diff 38515.Jan 27 2018, 8:00 AM

Swap out "nullfs" for its XML entity.

mat requested changes to this revision.Jan 27 2018, 8:34 AM

While this sed -e 's/93/111/' seems nice, it is really not needed.

People are assumed to be intelligent enough to be able to understand what the command do, and what the small bits mean.

en_US.ISO8859-1/books/porters-handbook/testing/chapter.xml
460–466 ↗(On Diff #38515)

That is probably the only interesting bit in all these changes. The version passed to -v needs to be head though.

You should probably add to the note that to be able to use the 12-CURRENT jail the host must be running 12-CURRENT.

This revision now requires changes to proceed.Jan 27 2018, 8:34 AM
seanc updated this revision to Diff 38516.Jan 27 2018, 8:57 AM
seanc marked an inline comment as done.

Update comments from @mat

seanc added a comment.Jan 27 2018, 9:01 AM
In D14067#295466, @mat wrote:

While this sed -e 's/93/111/' seems nice, it is really not needed.
People are assumed to be intelligent enough to be able to understand what the command do, and what the small bits mean.

Sure. While I was looking through the docs, this struck me as old enough to warrant a refresh in order to give the appearance of not being out of date. Stale docs that don't have current version numbers or dates are less trustworthy to newer users.

emaste added a subscriber: emaste.Jan 27 2018, 1:16 PM

I agree with @seanc; we can expect users to understand 93 as a placeholder for some version, referencing old versions or dates gives the impression that the document as a whole is might have outdated information.

sevan updated this revision to Diff 41178.Apr 6 2018, 2:21 PM
sevan added a subscriber: sevan.

Revamp changeset to include only the note on older version jails on head.

sevan added a comment.Apr 6 2018, 2:25 PM

Apologies, I misread the last comment. Let me see if I can undo my changes.

sevan updated this revision to Diff 41179.Apr 6 2018, 2:52 PM

Put back the origin changes proposed by @seanc.

bcr added a subscriber: bcr.Apr 6 2018, 3:12 PM

Only two small nits that I found.

en_US.ISO8859-1/books/porters-handbook/testing/chapter.xml
468 ↗(On Diff #41179)

I think there needs to be a comma after "In general".

476 ↗(On Diff #41179)

There is a ) missing here.

sevan updated this revision to Diff 41181.Apr 6 2018, 3:16 PM

Address nits.

bcr accepted this revision.Apr 6 2018, 3:58 PM

Excellent, I think this can go in now.
Thank you for working on it.

This revision was not accepted when it landed; it landed in state Needs Review.Apr 6 2018, 4:20 PM
This revision was automatically updated to reflect the committed changes.