Minimum changes for ctl to build on architectures with non-matching physical and virtual address sizes
ClosedPublic
Actions

Authored by jhibbits on Jan 25 2018, 4:43 AM.

Details

Reviewers

mav
chuck

Commits

rS328425: Minimum changes for ctl to build on architectures with non-matching physical and

Summary

Some architectures use physical addresses larger than virtual. This is the
minimal changeset needed to get CAM/CTL to build on these targets. No
functional changes. More changes would likely be needed for this to be fully
functional on said platforms, but they can be made when needed.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jhibbits created this revision.Jan 25 2018, 4:43 AM

Herald added a subscriber: imp. · View Herald TranscriptJan 25 2018, 4:43 AM

Harbormaster completed remote builds in B14565: Diff 38422.Jan 25 2018, 4:43 AM

Looks good to me.

This revision is now accepted and ready to land.Jan 25 2018, 5:35 PM

I think it really may be the actual fix, since those code paths seems to be only working with virtual addresses any way. IIRC we have no places where CTL and its infrastructure would really need to use physical addresses at this point.

Closed by commit rS328425: Minimum changes for ctl to build on architectures with non-matching physical and (authored by jhibbits). · Explain WhyJan 26 2018, 12:58 AM

This revision was automatically updated to reflect the committed changes.