Page MenuHomeFreeBSD

Do a bit of explanation on implementation choice we made WRT range expressions
AcceptedPublic

Authored by yuripv_icloud.com on Jan 23 2018, 8:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 30, 6:24 PM
Unknown Object (File)
Tue, Apr 30, 6:22 PM
Unknown Object (File)
Tue, Apr 30, 6:22 PM
Unknown Object (File)
Tue, Apr 30, 3:43 PM
Unknown Object (File)
Dec 25 2023, 12:25 AM
Unknown Object (File)
Dec 20 2023, 3:01 AM
Unknown Object (File)
Dec 14 2023, 11:19 PM
Unknown Object (File)
Dec 13 2023, 5:00 AM
Subscribers

Details

Reviewers
kevans
Group Reviewers
manpages
Summary
  • add comment in regcomp.c
  • add the same in regex(3)

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

lib/libc/regex/regex.3
615

This belongs up above in the "IMPLEMENTATION CHOICES" section (see line 532); the explicit reference to IEEE Std 1003.2 can be dropped there, because that section is dedicated to how we handle behavior explicitly defined as undefined.

lib/libc/regex/regex.3
615

It *is* in implementation choices section, and I did use the reference to distinguish between what specifications says and what we have chosen to implement -- see a "backslashed character" paragraph a bit above making the same reference.

lib/libc/regex/regex.3
615

Whoops, misread a cross-reference up above. My bad. =)

I don't care much for the redundancy up there either, but it makes sense: it wants to say "given a magic meaning by [The Standard]"; this is implied in most of the other implementation choices as well, but we don't tend to repeat that- this would've been written to basically chop off everything before "expression ranges" following the structure of these.

I don't feel strongly enough about it to request it to be changed, though.

lib/libc/regex/regex.3
615

Then I'll need your help here as I can't properly rephrase without the standard reference :-) (sorry not a native speaker).

update wording in man page a bit

lib/libc/regex/regex.3
615

Hopefully it looks better now?

lib/libc/regex/regex.3
615

Looks good to me

kevans added a subscriber: yuripv.

LGTM; tag new account @yuripv

This revision is now accepted and ready to land.Apr 22 2019, 5:22 PM