Page MenuHomeFreeBSD

Fix build of textproc/qt4-clucene on aarch64. The error message is similar to a lot of the recent clang6 fixes, but doesn't show up on amd64: ../../../../src/3rdparty/clucene/src/CLucene/queryParser/Lexer.cpp:120:23: error: non-constant...
ClosedPublic

Authored by adridg on Jan 19 2018, 10:37 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jun 5, 2:07 PM
Unknown Object (File)
May 3 2024, 9:43 AM
Unknown Object (File)
May 3 2024, 8:09 AM
Unknown Object (File)
Apr 3 2024, 11:34 AM
Unknown Object (File)
Dec 20 2023, 2:43 AM
Unknown Object (File)
Dec 1 2023, 3:22 AM
Unknown Object (File)
Nov 1 2023, 8:54 AM
Unknown Object (File)
Sep 28 2023, 4:30 AM
Subscribers

Details

Summary

...-expression cannot be narrowed from type 'int' to 'wchar_t' in initializer list [-Wc++11-narrowing]

TCHAR buf[2] = {ch,'\0'};

static_cast<> it away.

Test Plan

Builds on aarch64 and amd64

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

"while here, make makepatch to nicely name the pre-existing patch file"

You can revert the file name chang to the other patch.

After that it's good to go.

This revision is now accepted and ready to land.Jan 19 2018, 10:42 PM

"while here, make makepatch to nicely name the pre-existing patch file"

sorry, got side-tracked while typing the answer (looking at qt5-help which had clucene too before).

There is not much gained by renaming the patch apart from making portlint happy. I would keep them named like this until there is an actual content change in them.

This revision was automatically updated to reflect the committed changes.